From ffa11daea92de38343599cad512276439377c7ae Mon Sep 17 00:00:00 2001
From: William Stein <wstein@sagemath.com>
Date: Wed, 11 Dec 2024 00:35:58 +0000
Subject: [PATCH] delete some tests that are failing

- represent behavior we don't want anymore
- uses mocks when NOT necessary, which makes them much more difficult to
  maintain
---
 .../purchases/shopping-cart-checkout.test.ts  | 86 -------------------
 .../purchases/shopping-cart-checkout.ts       |  1 +
 src/packages/server/shopping/cart/get.ts      |  1 +
 3 files changed, 2 insertions(+), 86 deletions(-)

diff --git a/src/packages/server/purchases/shopping-cart-checkout.test.ts b/src/packages/server/purchases/shopping-cart-checkout.test.ts
index 10126e76e0..12eaa3f2ef 100644
--- a/src/packages/server/purchases/shopping-cart-checkout.test.ts
+++ b/src/packages/server/purchases/shopping-cart-checkout.test.ts
@@ -52,92 +52,6 @@ afterEach(() => {
 });
 
 describe("shopping-cart-checkout", () => {
-  describe("#shoppingCartCheckout", () => {
-    const account_id = uuid();
-    const testCheckout = {
-      account_id,
-    };
-
-    const testPoolClient = {
-      query: jest.fn(),
-      release: jest.fn(),
-    };
-
-    it("uses account balance when available", async () => {
-      // Arrange
-      //
-      jest.spyOn(sut, "getShoppingCartCheckoutParams").mockReturnValue(
-        Promise.resolve({
-          balance: NaN,
-          minPayment: NaN,
-          amountDue: 0.0,
-          chargeAmount: 0.0,
-          total: NaN,
-          minBalance: NaN,
-          minimumPaymentCharge: NaN,
-          cureAmount: NaN,
-          cart: [],
-        }),
-      );
-
-      mockTransactionClient.mockImplementation(() =>
-        Promise.resolve(testPoolClient as any),
-      );
-
-      // Act
-      //
-      await sut.shoppingCartCheckout({
-        ...testCheckout,
-      });
-
-      // Assert
-      //
-      expect(testPoolClient.query).toHaveBeenCalledWith("COMMIT");
-      expect(testPoolClient.release).toHaveBeenCalled();
-    });
-
-    it("bails on the shopping cart transaction when shopping cart purchase fails", async () => {
-      // Arrange
-      //
-      jest.spyOn(sut, "getShoppingCartCheckoutParams").mockReturnValue(
-        Promise.resolve({
-          balance: NaN,
-          minPayment: NaN,
-          amountDue: NaN,
-          chargeAmount: 2,
-          total: NaN,
-          minBalance: NaN,
-          minimumPaymentCharge: NaN,
-          cureAmount: NaN,
-          cart: [
-            {
-              foo: "bar",
-            },
-          ],
-        }),
-      );
-
-      const ackbError = new Error(
-        "Insufficient credit on your account to complete the purchase (you need $2.00). Please refresh your browser and try again or contact support.",
-      );
-
-      mockTransactionClient.mockImplementation(() =>
-        Promise.resolve(testPoolClient as any),
-      );
-      mockPurchaseShoppingCartItem.mockImplementation(() => {
-        throw ackbError;
-      });
-
-      // Act
-      //
-      await expect(
-        sut.shoppingCartCheckout({
-          ...testCheckout,
-        }),
-      ).rejects.toThrow(ackbError);
-    });
-  });
-
   describe("#getCheckoutCart", () => {
     const account_id = uuid();
 
diff --git a/src/packages/server/purchases/shopping-cart-checkout.ts b/src/packages/server/purchases/shopping-cart-checkout.ts
index d188e989fe..9a2167ce8c 100644
--- a/src/packages/server/purchases/shopping-cart-checkout.ts
+++ b/src/packages/server/purchases/shopping-cart-checkout.ts
@@ -133,6 +133,7 @@ export async function getCheckoutCart(
     processing,
     cart_ids,
   });
+  console.log({ cart });
   cart = cart.filter(
     filter ??
       ((item) =>
diff --git a/src/packages/server/shopping/cart/get.ts b/src/packages/server/shopping/cart/get.ts
index 00bef2cb63..d1d2753afa 100644
--- a/src/packages/server/shopping/cart/get.ts
+++ b/src/packages/server/shopping/cart/get.ts
@@ -79,6 +79,7 @@ export default async function getCart({
   }
   const { rows } = await pool.query(query, params);
   await ensureValidLicenseIntervals(rows, pool);
+  console.log({ query, rows });
   return rows as any as Item[];
 }