Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close transaction flow if Safe changes #2526

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Sep 19, 2023

What it solves

Resolves #2499

How this PR fixes it

The transaction modal now closes if the Safe changes.

How to test it

  1. Ensure the transaction modal is open.
  2. Change Safe.
  3. Observe the modal close.

The same should also happen with the a Safe of the same address, but different chain.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh September 19, 2023 16:08
@iamacook iamacook self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Branch preview

✅ Deploy successful!

https://tx_flow_address_change--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good. Tried every tx form (send funds, owner adding/removal, policies, spending limits..) and changing safes takes you to the new safe's dashboard

Jago was kind enough to provide 2 safes with the same address in different networks to test.
Looks good to me

@iamacook iamacook merged commit 37e6faf into dev Sep 21, 2023
9 checks passed
@iamacook iamacook deleted the tx-flow-address-change branch September 21, 2023 07:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tx details] Tx details is not closed when another safe is selected
3 participants