Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global notifications Save button is enabled when no safe is selected #4655

Open
usame-algan opened this issue Dec 13, 2024 · 1 comment
Open

Global notifications Save button is enabled when no safe is selected #4655

usame-algan opened this issue Dec 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@usame-algan
Copy link
Member

Bug description

Selecting and de-selecting all safes in global notifications view still keeps the Save button enabled.

Steps to reproduce

  1. Go to /settings/notifications
  2. Have at least one added safe
  3. Observe that safe is visible in the list without a connected wallet
  4. Connect wallet
  5. Select all
  6. Observe the Save button becomes enabled
  7. Deselect all

Expected result

The Save button is disabled

Obtained result

The Save button is enabled

Screenshots

Screenshot 2024-12-13 at 12 38 16
@usame-algan usame-algan added the bug Something isn't working label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Dec 13, 2024
@usame-algan usame-algan mentioned this issue Dec 13, 2024
Merged
3 tasks
@usame-algan
Copy link
Member Author

We should also evaluate if the CheckWallet component is needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Web Squad
Status: New issues
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usame-algan