Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing a tx with a safe-as-owner in zkSync #3141

Closed
liliya-soroka opened this issue Jan 22, 2024 · 0 comments · Fixed by #3369
Closed

Executing a tx with a safe-as-owner in zkSync #3141

liliya-soroka opened this issue Jan 22, 2024 · 0 comments · Fixed by #3369
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Jan 22, 2024

Bug description

This issue was reported initially on support: 5afe/safe-support#306

I tried to execute a tx in zkSync network and in the console the issue was: "invalid sender. can't start a transaction from a non-account"

NOTE:

I tried the same in goerli and I didn't had issues, so is possible this is an issue with the network

Environment

Browser: Chrome
Wallet: WC dApp (safe as owner)
Chain: zkSync Era Mainnet

Steps to reproduce

Have a safe 2/2. one owner can be a EOA and the 2nd must be a safe
Create a tx like adding an owner, with the EOA
Connect with the safe using the WC dApp
Try to execute the tx

Expected result

Tx can be executed normally

Obtained result

The estimation fails, the console shows the error
"invalid sender. can't start a transaction from a non-account"

#2631

@liliya-soroka liliya-soroka added bug Something isn't working minor Minor bug labels Jan 22, 2024
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Jan 22, 2024
@liliya-soroka liliya-soroka added major Major bug (to be solved in the next release) and removed minor Minor bug labels Feb 29, 2024
@jmealy jmealy self-assigned this Feb 29, 2024
compojoom added a commit that referenced this issue Feb 29, 2024
compojoom added a commit that referenced this issue Feb 29, 2024
compojoom added a commit that referenced this issue Feb 29, 2024
compojoom added a commit that referenced this issue Feb 29, 2024
@jmealy jmealy removed their assignment Mar 1, 2024
@liliya-soroka liliya-soroka moved this from New issues to In Progress in Safe{Wallet} Mar 1, 2024
@katspaugh katspaugh moved this from In Progress to Ready for QA in Safe{Wallet} Mar 4, 2024
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Mar 5, 2024
@liliya-soroka liliya-soroka moved this from QA in progress to Ready for QA in Safe{Wallet} Mar 5, 2024
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Mar 5, 2024
@liliya-soroka liliya-soroka moved this from QA in progress to QA done in Safe{Wallet} Mar 6, 2024
@github-project-automation github-project-automation bot moved this from QA done to Done in Safe{Wallet} Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants