Release 1.20.0 #2702

katspaugh · 2023-10-30T06:58:41Z

Features

Native WalletConnect (Feat: native WalletConnect #2535)

Improvements & bug fixes

feat: track user's wallet type through user properties (feat: track user's wallet type through user properties #2688)
Fix: show nonce warning when above current nonce (Fix: show nonce warning when above current nonce #2625)
fix: after-install in Docker (Chore: after-install in Docker #2700)
Fix: uncaught exception in ApprovalEditor (Fix: uncaught exception in ApprovalEditor #2674)
fix: clear awaiting confirmation notifications (fix: clear awaiting confirmation notifications #2588)
fix: Track transaction item open events (fix: Track transaction item open events #2602)
fix: Adjust safe creation event to include safeAddress (fix: track safeAddress on Safe creation #2648)
Update nextjs to v13.5 (chore: Update nextjs to v13.5 #2539)

Tests & chores

Tests: Migrate safe apps tests to Sepolia (Tests: Migrate safe apps tests to Sepolia #2680)
Tests: Migrate Smoke tests to Sepolia (Tests: Migrate Smoke tests to Sepolia #2670)
Tests: Add Assets tests (Tests: Add Assets tests #2624)
Tests: Add create safe tests (Add create safe tests #2611)
Tests: Add Remove owner tests (Tests: Add Remove owner tests #2587)
Chore: enable unit test coverage comment (Chore: enable unit test coverage comment #2637)
chore: mock data builder for tests (chore: mock data builder for tests #2675)
Refactor: map props to hooks (Refactor: map props to hooks #2564)
fix: console warnings in owner list (fix: console warnings in owner list #2612)
Fix: use local ExplorerButton component (Fix: use local ExplorerButton component #2685)
Fix: key prop in HumanDescription (Fix: key prop in HumanDescription #2698)

* fix: clear awaiting confirmation notifications * fix: clear notifications for messages

* Add Create Safe tests * Remove unused import

* fix: Only track fetch details event if tx details are fetched * fix: Track accordion open instead of tx details fetch, rename event * fix: Track every accordion open

* fix: console warnings in owner list * fix: duplicate tooltips * fix: e2e tests * fix: button selectors * revert: add owner button selector

* Add Assets tests * Update test description

* chore: Update nextjs to v13.5 * fix: Replace optimizeImports with optimizePackageImports * chore: Update lockfile * Rm next-pwa patch * Fix type issues * Rm protobuf * Fix tests * Fix apps.test.tsx --------- Co-authored-by: katspaugh <[email protected]>

* Fix: show nonce warning when above current nonce * Lint * Adjust text

* Refactor: map props to hooks * Appeace linter * Display name * Test: run postinstall manually * Restire yarn action * Memoize component * Only map * Add tests * Add a comment and rename the param * Add an export dialog test

* Chore: enable unit test coverage comment * Disable pre-commit lint * Always comment * Try a different report action * Run tests from the action * Custom test command * Make a failing test * Fix test

* Migrate tests to Seplia * Remove unused import * Fix tests

* feat: mock data builder for tests * refactor: pass override object

* Migrate safe apps and NFTS tests to Sepolia * Fix tests * Remove dashboard and nfts tests from test run

* Feat: native walletconnect * Multi-session * fix: handle optional chain session approvals * Popup * fix: forward ref * Update session; disconnect session * feat: connection popper * refactor: assertion + get errors from WC * Pass all required methods as compatible * fix: modal style/position + types * fix: switch to current chain after approval * feat: sync chain and address * Refactor approve/reject * Refactor: session manager * SafeWalletProvider * Add a session_delete handler * feat: add verification * fix: reject session when manager closes * fix: connection modal + no manual session setting * Simplify and fix useSessions * Refactor: extract proposal verification into a component * wip: send added safes in namespace * revert: getActiveSessions * Revert added safes + add wallet_switchEthereumChain * fix: use `wc_sessionSettle` for added sessions * Revert "fix: use `wc_sessionSettle` for added sessions" This reverts commit 16e5b98. * Fix: emit session_add after try-catch * Pass peer name and icon to tx flow * Peer icon/count on the header widget * Send app.url * fix: keep session aligned with peer * refactor: only update session if required * fix: add partial `WalletConnectWallet` tests * fix: add remaining tests for `WalletConnectWallet` * SafeWalletProvider tests * fix: add `useWalletConnectSessions` test coverage * useSafeWalletProvider tests (WIP) * fix: add tests for `WalletConnectContext` * fix: add `onRequest` tests + move tests * Revert "fix: add `onRequest` tests + move tests" This reverts commit 0184e78. * Revert "fix: add tests for `WalletConnectContext`" This reverts commit 5c08405. * fix: add context test * Resore yarn lock Pin next-pwa * feat: connect to session in URL * refactor: move autoconnection to context * fix: header logo + add error response * Revert "fix: header logo + add error response" This reverts commit 5132dd5. * fix: don't cut off DApp icon (#2594) * fix: update session after approval (#2595) * fix: return error if request is from wrong chain * fix: update session after approval * Return txHash if available (#2616) * fix: styling (#2617) * Fix optional txId * fix: populate help section (#2619) * fix: populate help section * refactor: extract constants + debounce hints * fix: align all `Popover`s to header (#2623) * fix: address WC style feedback (#2621) * feat: wrong network warning + high risk checkbox (#2622) * feat: wrong network warning + high risk checkbox * refactor: merge/improve chain warnings * fix: simplify chain mismatch message * fix: change colour of icon + add error badge (#2627) * fix: extend Safe wallet provider tests (#2608) * fix: extend Safe wallet provider tests * fix: WC search param test * fix: WC popup, checkbox, session alignment (#2636) * fix: WC popup, checkbox, DApp name alignment * fix: add gap + remove import * fix: centralise error * fix: lock file * feat: show notifications for WC requests (#2638) * feat: show notifications for WC requests * refactor: move notification logic to own file * fix: disable approval of unsupported sessions (#2639) * fix: disable approval of unsupported sessions * fix: rephrase info + variable * fix: rename "chains" to "networks * feat: enter pairing URI from clipboard on focus (#2630) * feat: enter pairing URI from clipboard on focus * fix: display session manager immediately * fix: drill prepopulated pairing URI * fix: remove function + check clipboard prefix * fix: clear clipboard * fix: don't set clipboard + move validation to hook * fix: show WC details in transaction list (#2641) * fix: clear pairing URI on rejection (#2643) * fix: clear pairing URI on rejection * fix: don't check for permissions on Firefox * fix: rename variable * fix: WC session list height (#2642) * fix: session management when switching chains (#2640) * fix: session management when switching chains * fix: move function to private method * fix: enable header, grey out sessions + don't add chains * fix: session badge, hint dismissal + improve info (#2646) * fix: `useSafeWalletProvider` test * fix: don't paste stale pairing URIs (#2649) * fix: WC signatures + subsequent transactions (#2650) * fix: reject requests on flow change * fix: success doesn't quit + unsubscriptions * refactor: cleanup code * fix: change event payload + use callback syntax * feat: on-chain WC signing (#2654) * feat: block/warn about bridges accordingly (#2652) * feat: block/warn about bridges accordingly * fix: abstract constants + rename variables * fix: multipl session disconnects throwing (#2655) * fix: help block not hiding (#2658) * fix: remove secondary help block display state * fix: unit tests * fix: lint * fix: handle empty metadata (#2660) * fix: handle empty metadata * fix: don't render icon * fix: add fallback for * fix: emit `chainChanged` first (#2661) * fix: emit first * fix: remove only from test * fix: prevent error from blocking WC popup (#2663) * Feat: open WC popup on dashboard widget click (#2662) * Feat: open WC popup on dashboard widget click * Lint * fix: don't reject when signing (#2666) * fix: don't reject when signing * fix: comment * feat: unsupported chain disconnection feedback (#2664) * feat: unsupported chain disconnection feedback * refactor: create useDeferredListener hook * Refactor: rename and rearrange components (#2676) * Refactor: rename and rearrange components * Move useWcUri * Show/hide popup on session change * Remove auto-pasting * Hide input when no Safe is opened * Warned bridge should not disable Approve * Fix: peer and metadata can be undefined * Handle pair errors * Add comments * Add dots animation * Reword warning * Add a network switch in the proposal form * Update WC version * Reset error * Name can be empty * Detect bridges by name * Increase clickable area for header buttons * Fix: always add safe methods * Fix tests * Fix: don't display chain switch errors to the user, just log them * Add tracking * Add onboarding tooltip * Header icon badges * Make dapp icon larger * Update header icons * Fix tests * Refactor: track tx origin (#2647) * Feat: track tx origin * Add unit test * Blink title when WC tx is created * Fix USER_QUIT * Fix: add another bridge * Fix: disable Approve button on non-Safe urls * Fix: clear proposal if rejection fails * Add more unsupported bridges; adjust warning text * Feat: show sample dapps to connect (only once) * Fix: show a better pairing code error * [WalletConnect] Feat: add extra tracking events (#2693) * Feat: add extra tracking events * Fix tests * Fix: debounce input error tracking * Feature toggle * Fix: on close callback for WalletConnect (#2696) * Refactor: on close callback for WalletConnect * Use safeAddress + chainId instead of raw query * Close modal on path change * Fix lint * Fix: track hints only when popup is open * Fix: no close warning when resetting txFlow * Stabilize e2e tests * Replace tx flow should not warn * Fix safe apps msg parsing * fix e2e --------- Co-authored-by: iamacook <[email protected]>

github-actions · 2023-10-30T06:58:55Z

Branch preview

✅ Deploy successful!

https://release_1_20_0--walletweb.review-wallet-web.5afe.dev

github-actions · 2023-10-30T07:02:19Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2023-10-30T07:10:32Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	75.32%	9432/12522
🔴	Branches	49.5%	1925/3889
🔴	Functions	58.21%	1421/2441
🟡	Lines	76.96%	8537/11093

Test suite run success

1045 tests passing in 142 suites.

Report generated by 🧪jest coverage report action from 21a8909

liliya-soroka · 2023-10-30T09:05:39Z

Small UI bug in the "How do I interact with dapps - wrong network is displayed in how to
Steps:

open app
switch the network using drop-down in the right corner
open how do I interact ...
Current result: The network that was used during the app opening is displayed in the instruction
refresh the page manually and check the network in the how to ...
Current result: the correct network is displayed

liliya-soroka · 2023-10-30T09:17:13Z

Connect to Opensea doesn't work on Arbitrum
Steps:

try to connect safe to the Opensea on Arbitrum
Current result: Either the error is displayed on opensea side or the QR code dialog is not closed.
Connection appears on safe side
Could we check if it's not our side issue?

katspaugh · 2023-10-30T10:53:04Z

src/components/walletconnect/WcHints/index.tsx

@@ -88,10 +84,6 @@ const WcHints = (): ReactElement => {
    trackEvent(WALLETCONNECT_EVENTS.HINTS_EXPAND)
  }

-  if (chain?.chainName) {
-    InteractionSteps[1] = InteractionSteps[1].replace(/%%chain%%/, chain?.chainName)


@iamacook FYI. You should never modify constants like this.

* feat: track user's wallet through user properties * fix: add enum for user properties * fix: move user properties to types.ts and add test * fix: only set walletLabel if defined * lint: remove unused import

iamacook and others added 21 commits October 10, 2023 15:16

fix: clear awaiting confirmation notifications (#2588)

1d6b5d2

* fix: clear awaiting confirmation notifications * fix: clear notifications for messages

Tests: Add create safe tests (#2611)

fc11072

* Add Create Safe tests * Remove unused import

fix: Track transaction item open events (#2602)

e43d777

* fix: Only track fetch details event if tx details are fetched * fix: Track accordion open instead of tx details fetch, rename event * fix: Track every accordion open

fix: console warnings in owner list (#2612)

f263f3d

* fix: console warnings in owner list * fix: duplicate tooltips * fix: e2e tests * fix: button selectors * revert: add owner button selector

Tests: Add Assets tests (#2624)

51b2889

* Add Assets tests * Update test description

Fix: show nonce warning when above current nonce (#2625)

a9c36ee

* Fix: show nonce warning when above current nonce * Lint * Adjust text

Refactor: map props to hooks (#2564)

2781684

* Refactor: map props to hooks * Appeace linter * Display name * Test: run postinstall manually * Restire yarn action * Memoize component * Only map * Add tests * Add a comment and rename the param * Add an export dialog test

Chore: enable unit test coverage comment (#2637)

7040aee

* Chore: enable unit test coverage comment * Disable pre-commit lint * Always comment * Try a different report action * Run tests from the action * Custom test command * Make a failing test * Fix test

Chore: Jest CI: annotations only for failed tests (#2645)

8189cd7

Update tests (#2651)

d81ee92

Tests: Migrate Smoke tests to Sepolia (#2670)

edd6923

* Migrate tests to Seplia * Remove unused import * Fix tests

chore: mock data builder for tests (#2675)

b1b5871

* feat: mock data builder for tests * refactor: pass override object

Tests: Migrate safe apps tests to Sepolia (#2680)

0c1896f

* Migrate safe apps and NFTS tests to Sepolia * Fix tests * Remove dashboard and nfts tests from test run

Fix: uncaught exception in ApprovalEditor (#2674)

77f8862

Fix: use local ExplorerButton component (#2685)

2bb71d1

fix: Adjust safe creation event to include safeAddress (#2648)

584eed7

Fix: key prop in HumanDescription (#2698)

04cd78f

Chore: after-install in Docker (#2700)

9c9e54e

1.20.0

f00bf3d

katspaugh requested a review from usame-algan October 30, 2023 06:58

katspaugh added 2 commits October 30, 2023 08:53

Chore: fix unit tests

4492a6a

Fix: don't show wc tooltip if no safe

e3a00ed

katspaugh commented Oct 30, 2023

View reviewed changes

schmanu and others added 2 commits October 30, 2023 11:54

feat: track user's wallet type through user properties (#2688)

aa3ddab

* feat: track user's wallet through user properties * fix: add enum for user properties * fix: move user properties to types.ts and add test * fix: only set walletLabel if defined * lint: remove unused import

Fix: don't modify hint constants

21a8909

katspaugh force-pushed the release/1.20.0 branch from cd5af8b to 21a8909 Compare October 30, 2023 10:54

katspaugh merged commit 21a8909 into main Oct 30, 2023
8 of 10 checks passed

katspaugh deleted the release/1.20.0 branch October 30, 2023 12:21

github-actions bot locked and limited conversation to collaborators Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.20.0 #2702

Release 1.20.0 #2702

katspaugh commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

liliya-soroka commented Oct 30, 2023

liliya-soroka commented Oct 30, 2023 •

edited

Loading

katspaugh Oct 30, 2023

Release 1.20.0 #2702

Release 1.20.0 #2702

Conversation

katspaugh commented Oct 30, 2023 • edited Loading

Features

Improvements & bug fixes

Tests & chores

github-actions bot commented Oct 30, 2023 • edited Loading

Branch preview

github-actions bot commented Oct 30, 2023 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Oct 30, 2023 • edited Loading

Coverage report

Test suite run success

liliya-soroka commented Oct 30, 2023

liliya-soroka commented Oct 30, 2023 • edited Loading

katspaugh Oct 30, 2023

Choose a reason for hiding this comment

katspaugh commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

liliya-soroka commented Oct 30, 2023 •

edited

Loading