Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot easily scroll to end on Confirm Transaction screen #2690

Closed
DefiDebauchery opened this issue Oct 24, 2023 · 2 comments · Fixed by #3961
Closed

Cannot easily scroll to end on Confirm Transaction screen #2690

DefiDebauchery opened this issue Oct 24, 2023 · 2 comments · Fixed by #3961
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DefiDebauchery
Copy link

DefiDebauchery commented Oct 24, 2023

Bug description

When signing transactions with a large number of steps, the Sign button, located on the bottom of the page, becomes less accessible. While a mouse scrollwheel works, you would typically be able to use End or Cmd-Down (Mac) on the keyboard to quickly move the viewport to the bottom; however, the structure of the page does not allow this.

Environment

  • Browser: Chrome
  • Wallet: Rabby
  • Chain: Optimism

Steps to reproduce

  1. Create a MultiSend or other transaction that enables a scrollbar on the Confirm Transaction screen
  2. Try to quickly access the Sign button, located at the bottom of the page

Expected result

One should be able to use End or Cmd-Down to move the viewport to the bottom of the page.

Obtained result

The viewport does not move, despite the scrollbar.

Screenshots

Screenshot 2023-10-24 at 10 55 07 AM

@DefiDebauchery DefiDebauchery added the bug Something isn't working label Oct 24, 2023
@usame-algan
Copy link
Member

Possibly related to #2682

@liliya-soroka
Copy link
Member

A quick way to reproduce :

  1. Open. transaction builder
  2. upload json file -
    supreme working batch.json - Click "Ok, I understand"
  3. Click "create batch" and "send batch"
    Confirm tx page with many actions will be opened:
image

@liliya-soroka liliya-soroka added the good first issue Good for newcomers label Feb 15, 2024
@jmealy jmealy moved this from New issues to In Progress in Safe{Wallet} Jul 15, 2024
@jmealy jmealy self-assigned this Jul 15, 2024
@jmealy jmealy moved this from In Progress to Peer Review in Safe{Wallet} Jul 17, 2024
@jmealy jmealy moved this from Peer Review to Ready for QA in Safe{Wallet} Jul 17, 2024
@francovenica francovenica moved this from Ready for QA to Ready to merge in Safe{Wallet} Jul 18, 2024
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Safe{Wallet} Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants