Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only request new notification signatures #2575

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 2, 2023

What it solves

Resolves signature requests for Safes that are already registered for notifications.

How this PR fixes it

The logic within the banner has been fixed, as well as more unit test coverage added.

How to test it

  1. Add a Safe on chain A and register for notifications with it.
  2. Add a Safe on chain B and register for notifications with it.
  3. Observe only one signature request.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh October 2, 2023 12:55
@iamacook iamacook self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Branch preview

✅ Deploy successful!

https://duplicate_notification_signatures--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good.

The Enable all is now asking to sign just by the amount of networks that have yet not signed: so if you have a safe added with notifications enabled, and add a new safe for a different network it will only ask to sign once more for that new added safe.

Also noticed that in dev "enable all" wasn't working if several safes were already added and had the notifications not enabled yet. In this PR that part works fine now

@iamacook iamacook merged commit 29148a8 into dev Oct 4, 2023
9 checks passed
@iamacook iamacook deleted the duplicate-notification-signatures branch October 4, 2023 07:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants