Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe v1.4.1 support #2558

Closed
3 tasks
katspaugh opened this issue Sep 27, 2023 · 7 comments · Fixed by #3209
Closed
3 tasks

Safe v1.4.1 support #2558

katspaugh opened this issue Sep 27, 2023 · 7 comments · Fixed by #3209
Assignees

Comments

@katspaugh
Copy link
Member

katspaugh commented Sep 27, 2023

This 1.4.1 Safe can be used for testing: https://safe-wallet-web.staging.5afe.dev/transactions/history?safe=gor:0xD9F842c3F12fDf58b46703903BBEAba6da4888c5 (created by @Uxio0 via the CLI).

  • It currently shows this error when creating a tx:

image

It might be related to the fact that safe-deployments don't yet have all the deployments for this version. Specifically Goerli is still missing, which explains the error above.

  • Error on safe opening using a URL in the UI
image
  • Fallback handler is marked as untrusted
image
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Sep 27, 2023
@liliya-soroka liliya-soroka self-assigned this Sep 28, 2023
@chronicIntrovert
Copy link

This preview can recognize Bitski accounts utilizing the Safe 1.4.1 contracts, but won't allow import. Is there anything we can do to support importing via safe.global?

Sample Safe contract account: https://polygonscan.com/address/0x9082269eeb932d7e697dbdf62d6b2d9fae4302c3#code

Screenshot 2023-10-03 at 7 56 42 PM Screenshot 2023-10-03 at 7 56 53 PM

@katspaugh
Copy link
Member Author

We don't support deployments that are not in https://github.com/safe-global/safe-deployments.

@chronicIntrovert
Copy link

We don't support deployments that are not in https://github.com/safe-global/safe-deployments.

Can anyone add to deployments there? Or is this only deployed contracts by Safe DAO?

@ptescher
Copy link

@katspaugh I think the indexer is not working due to https://github.com/safe-global/safe-eth-py/pull/691/files

image

@Uxio0
Copy link
Member

Uxio0 commented Nov 21, 2023

v1.4.1 singletons are now supported on the tx service (when available on https://github.com/safe-global/safe-deployments)

Can anyone add to deployments there? Or is this only deployed contracts by Safe DAO?

Anyone can propose deployments there, as long as they follow the same deterministic addresses, and we will merge

@ptescher
Copy link

This is now working for me!

@katspaugh
Copy link
Member Author

Blocked by #1984. The legacy Safe Core SDK only supports Safes up to 1.3.0.

@katspaugh katspaugh removed the blocked label Jan 17, 2024
@katspaugh katspaugh moved this from New issues to Todo in Safe{Wallet} Jan 17, 2024
@katspaugh katspaugh moved this from Todo to In Progress in Safe{Wallet} Feb 6, 2024
@katspaugh katspaugh self-assigned this Feb 6, 2024
@katspaugh katspaugh moved this from In Progress to Ready for QA in Safe{Wallet} Feb 14, 2024
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Feb 14, 2024
@liliya-soroka liliya-soroka moved this from QA in progress to QA done in Safe{Wallet} Feb 14, 2024
@github-project-automation github-project-automation bot moved this from QA done to Done in Safe{Wallet} Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants