Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override bridged USDC token symbol to USDC.e in line with cultural norm #2344

Closed
DefiDebauchery opened this issue Nov 25, 2024 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@DefiDebauchery
Copy link

Similar to #1743, it would be helpful for bridged USDC tokens to be marked as such to prevent ambiguity. The established practice community-wide has been to rename the symbol to 'USDC.e' in displays, even though the symbol on-chain cannot change.

Polygon: 0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174
Optimism: 0x7F5c764cBc14f9669B88837ca1490cCa17c31607
Arbitrum: 0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8

This would make things easier from an automation side when using friendly labels through the /api/v1/safes/{address}/balances/ API endpoint, but more importantly reduces confusion throughout the Safe UI, including the asset list, Transaction history, and confirmation screens where only the symbol is printed.

@DefiDebauchery DefiDebauchery added the enhancement New feature or request label Nov 25, 2024
@Uxio0 Uxio0 self-assigned this Nov 29, 2024
@Uxio0
Copy link
Member

Uxio0 commented Nov 29, 2024

Done! Thanks for letting us know!

@JagoFigueroa could you check?

@Uxio0 Uxio0 closed this as completed Nov 29, 2024
@JagoFigueroa
Copy link

Looking good, un saludito 😄

@DefiDebauchery
Copy link
Author

Thanks so much! There is one last one that I didn't originally report, for zkSync - 0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4

vs https://safe-transaction-zksync.safe.global/api/v1/tokens/0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4/

Note that this token did actually get updated to USDC.e canonically, since the contract is upgradeable. Dunno if that's something to consider for the token indexer.

@Uxio0
Copy link
Member

Uxio0 commented Dec 3, 2024

Hi @DefiDebauchery , thanks for reporting! Our token indexer indexes once and never again, maybe that's something that we can do from time to time. Proxies are really tricky

@Uxio0
Copy link
Member

Uxio0 commented Dec 3, 2024

Done for zksync too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants