Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Migrate Safe Apps logic to web-core fork #103

Open
dasanra opened this issue Jul 15, 2022 · 0 comments
Open

Migrate Safe Apps logic to web-core fork #103

dasanra opened this issue Jul 15, 2022 · 0 comments
Assignees
Labels

Comments

@dasanra
Copy link

dasanra commented Jul 15, 2022

Part 1: Define the problem

What problem are you trying to solve?

Currently the web team is working on a big refactor of the web interface. In order to help them to move faster we can take ownership of all Safe Apps related components and views to migrate to the new refactor.

What value does this bring to our customer and/or our mission? What is the goal?

The goal is to help web team to work in this refactor faster. Safe Apps integration is a complex piece in the web interface, and it also makes sense that we use our knowledge to ensure that all functionality is migrated. We could also move some shared components and help them to improve the safe-react-components library in which our Safe Apps also rely.

While helping in this refactor the Safe Apps team will also start getting familiar with the new code base

How do we measure it?

Links:

https://www.notion.so/gnosis-safe/Milestones-2467ae4922c144e6809149565fef855a

Part 2: Shaping the problem

Problem Owner

Daniel Sa, Mikhail

Non Goal(s)

  • Adding new functionality in the new codebase

Solution

Solution 1

Overview
There is little context that could be added for this solution. Just migrate the existing implementation in the old codebase to the new codebase.

Rough Scoping & Timeline

We will consider the migration finished once all the functionality in the old codebase is also ready in the new codebase.
It's expected that we will need until end of september to finish the code migration. This means will also fall into the next roadmap cycle. Functionality to migrate includes:

  • Add custom safe app
  • App frame (loading app view)
  • Receiving messages from the SDK
  • Responding to READ messages from the SDK
  • Responding to WRITE messages from the SDK (Sending transactions, signing)
  • Bookmark safe apps
  • Search safe apps
  • Share Safe apps
  • Queue bar
  • Security warning for custom URLs
  • Ranked Safe Apps on the Dashboard
  • Safe Apps permission system

Risk(s), Key Trade Offs & Decisions

We will need to completely code freeze Safe Apps in the new codebase. This doesn't mean that bugs won't be fixed, only that new features in Safe Apps transaction handling and flow in web won't get any new future functionality until the new code base is production ready.

Concept Mocks

Open Questions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants