Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: enable selecting owner keys in safe creation #3415

Closed
DmitryBespalov opened this issue May 27, 2024 · 1 comment
Closed

Feature: enable selecting owner keys in safe creation #3415

DmitryBespalov opened this issue May 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@DmitryBespalov
Copy link
Contributor

User criticism: when creating a new safe and adding owners to it, a user is not able to add the generated owner key in-place. Instead, they have to tap "back" many times, navigate to settings menu, create an owner key, and restart safe creation again. That is inconvenient.

To make creating the safe with completely new owners more convenient, we add the "Owner Key" list as a source of address input for "add owner" section.

Example

When user is creating a safe
And taps "add owner"
Then a menu opens with "Owner Keys" option.

When user selects that option
Then list of existing owner keys opens with an "add" (plus, +) icon.

When user selects an address from the list (and potentially enters a passcode)
Then that address is added as an owner in the "create safe" form.

When user taps the "add" (+) action
And then generates, imports, or connects a new owner key and closes the details with "Done"
Then that new owner key is displayed in the list and is available for selection.

@DmitryBespalov DmitryBespalov self-assigned this May 27, 2024
@DmitryBespalov DmitryBespalov added the enhancement New feature or request label May 27, 2024
DmitryBespalov added a commit that referenced this issue May 27, 2024
* Add new "owner key list updated" internal notification
* Add "owner keys" option to the "select address" screen used in the safe creation
* Add long press gesture to an addresses to create or edit address book entry (or safe name, or owner key name) (GH-3416).
DmitryBespalov added a commit that referenced this issue May 27, 2024
…dress

GH-3415 add owner from owner keys; GH-3416 add address to address book.
@liliya-soroka
Copy link
Member

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants