Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: update "relay" routes #3395

Closed
DmitryBespalov opened this issue Feb 27, 2024 — with Slack · 4 comments
Closed

Maintenance: update "relay" routes #3395

DmitryBespalov opened this issue Feb 27, 2024 — with Slack · 4 comments
Labels
infrastructure Technical tasks, not user-facing

Comments

Copy link
Contributor

Data for the new relay endpoints: safe address, safe version

Affected requests:

POST /v1/relay/:chainId → /v1/chains/:chainId/relay

GET /v1/relay/:chainId/:safeAddress → /v1/chains/:chainId/relay/:safeAddress

Updated data structures for the POST request:

type Request = {
  to: string;
  data: string;
  gasLimit?: string;
	// ⚠️ New
  version?: string; // Defaults to "1.3.0"
}

Contact person: Frederico Sabino or Aaron Cook

@DmitryBespalov DmitryBespalov added the infrastructure Technical tasks, not user-facing label Feb 27, 2024 — with Slack
@iamacook
Copy link
Member

It would be preferable to always specify the version so that we can eventually remove the default.

@DmitryBespalov
Copy link
Contributor Author

Alright, here's a list of things to keep in mind to make it work on mobile:

thanks @schmanu and @liliya-soroka adjusting config and spotting where the issue might be.

@iamacook
Copy link
Member

iamacook commented Mar 5, 2024

* Sending any token or native coin to self is returning misleading error message in the API: https://github.com/safe-global/safe-client-gateway/blob/0a81757cd61b2ef6ba9b5fb615cb5a1f75c89ee3/src/domain/relay/limit-addresses.mapper.spec.ts#L346 and here https://github.com/safe-global/safe-client-gateway/blob/0a81757cd61b2ef6ba9b5fb615cb5a1f75c89ee3/src/domain/relay/limit-addresses.mapper.spec.ts#L371

Thank you for the feedback. We will look into updating the error message.

Edit: this has been changed.

@liliya-soroka
Copy link
Member

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Technical tasks, not user-facing
Projects
None yet
Development

No branches or pull requests

3 participants