Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EIP-3779 shortname for appchain #1072

Closed
wants to merge 2 commits into from
Closed

Conversation

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@emrme
Copy link
Author

emrme commented Dec 10, 2024

@yagopv @DaniSomoza pls approve

@yagopv
Copy link
Member

yagopv commented Dec 11, 2024

Hey @emrme. The config file in this repo is generated from the safe-deployments repo

Take a look to this doc page

A similar PR should be like this one

Once the safe-deployments package is released with your chain then we can update the SDK

@emrme
Copy link
Author

emrme commented Dec 11, 2024

Hey @yagopv, my PRs to safe-deployments repo are all merged already:

safe-global/safe-deployments#916
safe-global/safe-deployments#915
safe-global/safe-deployments#918
safe-global/safe-deployments#914

So now you are waiting for npm package release I guess?

@yagopv
Copy link
Member

yagopv commented Dec 11, 2024

So now you are waiting for npm package release I guess?

Yes, this will be included in the next protocol-kit release. Probably next week

@yagopv
Copy link
Member

yagopv commented Dec 12, 2024

Hey @emrme, a new version (v5.1.1) was published containing appchain networks. Thanks!

@yagopv yagopv closed this Dec 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants