Improve notification related types, refactor notification tests

safe-global · Nov 6, 2024 · bb16bc1 · bb16bc1
1 parent 6aa88ce
commit bb16bc1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/datasources/db/v1/entities/row.entity.ts b/src/datasources/db/v1/entities/row.entity.ts
@@ -9,6 +9,6 @@ export type Row = z.infer<typeof RowSchema>;
  */
 export const RowSchema = z.object({
   id: z.number().int(),
-  created_at: z.coerce.date(),
+  created_at: z.coerce.date(), // @TODO when migrated all the entities to TypeOrm Remove `.coerce`
   updated_at: z.coerce.date(),
 });
diff --git a/src/datasources/notifications/entities/notification-devices.entity.db.ts b/src/datasources/notifications/entities/notification-devices.entity.db.ts
@@ -1,4 +1,5 @@
 import { NotificationSubscription } from '@/datasources/notifications/entities/notification-subscription.entity.db';
+import { RowSchema } from '@/datasources/db/v1/entities/row.entity';
 import { DeviceType } from '@/domain/notifications/v2/entities/device-type.entity';
 import { UuidSchema } from '@/validation/entities/schemas/uuid.schema';
 import type { UUID } from 'crypto';
@@ -11,13 +12,10 @@ import {
 } from 'typeorm';
 import { z } from 'zod';
 
-export const NotificationDeviceSchema = z.object({
-  id: z.number(),
+export const NotificationDeviceSchema = RowSchema.extend({
   device_type: z.nativeEnum(DeviceType),
   device_uuid: UuidSchema,
   cloud_messaging_token: z.string(),
-  created_at: z.date(),
-  updated_at: z.date(),
 });
 
 @Entity('push_notification_devices')

diff --git a/src/routes/notifications/v1/notifications.controller.spec.ts b/src/routes/notifications/v1/notifications.controller.spec.ts
@@ -115,7 +115,7 @@ describe('Notifications Controller (Unit)', () => {
     Promise.reject(`No matching rule for url: ${url}`);
 
   describe('POST /register/notifications', () => {
-    it.each([5, 20, 100])(
+    it.each([5, 20])(
       'Success for a subscription with %i safe registrations',
       async (safeRegistrationLength: number) => {
         const registerDeviceDto = await buildInputDto(safeRegistrationLength);