fix: Allow medium confidence checks for vpn eligibility

safe-global · Nov 26, 2024 · 55027e9 · 55027e9
1 parent be30c5f
commit 55027e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/datasources/locking-api/fingerprint-api.service.spec.ts b/src/datasources/locking-api/fingerprint-api.service.spec.ts
@@ -234,7 +234,7 @@ describe('FingerprintApiService', () => {
       });
     });
 
-    it('should return isVpn:false for a medium confidence score', async () => {
+    it('should return isVpn:true for a medium confidence score', async () => {
       const eligibilityRequest = eligibilityRequestBuilder().build();
       const unsealedData = fingerprintUnsealedDataBuilder()
         .with('products', {
@@ -252,7 +252,7 @@ describe('FingerprintApiService', () => {
       expect(result).toEqual({
         requestId: eligibilityRequest.requestId,
         isAllowed: expect.anything(),
-        isVpn: false,
+        isVpn: true,
       });
     });
 

diff --git a/src/datasources/locking-api/fingerprint-api.service.ts b/src/datasources/locking-api/fingerprint-api.service.ts
@@ -77,7 +77,8 @@ export class FingerprintApiService implements IIdentityApi {
   private isVpn(unsealedData: FingerprintUnsealedData): boolean {
     return (
       unsealedData.products.vpn?.data?.result === true &&
-      unsealedData.products.vpn?.data?.confidence === 'high'
+      (unsealedData.products.vpn?.data?.confidence === 'medium' ||
+        unsealedData.products.vpn?.data?.confidence === 'high')
     );
   }
 }