Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lags, probably during autosave #1164

Open
Iey4iej3 opened this issue Mar 11, 2024 · 10 comments · May be fixed by #1175
Open

Lags, probably during autosave #1164

Iey4iej3 opened this issue Mar 11, 2024 · 10 comments · May be fixed by #1175
Labels
bug Something isn't working

Comments

@Iey4iej3
Copy link

Iey4iej3 commented Mar 11, 2024

Describe the bug

It seems that there are significant lags probably during autosave. A similar issue was solved months ago, and the current one appears only in very recent versions.

To reproduce

  1. Keep writing;
  2. Encounter the lag probably when an autosave is performed.

Expected behavior

No perceivable lag.

Saber version

v0.20.3

Device

  • Device: Samsung Tab S6 Lite
  • OS: Android 13

Anything else?

No response

@Iey4iej3 Iey4iej3 added the bug Something isn't working label Mar 11, 2024
@QubaB
Copy link
Contributor

QubaB commented Mar 11, 2024

  1. Are there images in note?
  2. Big amount of images?
  3. Large images?
  4. Or only hand writing?
  5. Do you synchronize to nextcloud?

@Iey4iej3
Copy link
Author

Iey4iej3 commented Mar 12, 2024

Only handwriting, and ~ 25 pages (@QubaB Sorry, previously I mistakenly opened another note and the number of pages is now corrected, although I have not tested systematically whether this could happen for documents with fewer pages). Synchronize to the official server.

@QubaB
Copy link
Contributor

QubaB commented Mar 13, 2024

I observe lag during autosave (created testing note with 10 pages of handwriting).

I do not know if this can be avoided. I do not understand source code enough to see if saving is done in another thread (on background) or whole Saber runs in only one thread and then saving should produce lags.

@QubaB
Copy link
Contributor

QubaB commented Mar 14, 2024

I think that lag is caused by creation of note thumbnail during each Save. When I turned off creation of thumbnails (in developer version), lagging was not almost noticable.

I will try to create fix, which will implement that during autosave is not created thumbnail.

@Iey4iej3
Copy link
Author

I do not understand source code enough to see if saving is done in another thread (on background) or whole Saber runs in only one thread and then saving should produce lags.

It is done in background: #179 (comment)

@Iey4iej3
Copy link
Author

I think that lag is caused by creation of note thumbnail during each Save.

I guess that thumbernails should be produced when the notes are closed. Doing it during autosaves does not seem to be meaningful, indeed.

@QubaB QubaB linked a pull request Mar 15, 2024 that will close this issue
@Polux49
Copy link
Contributor

Polux49 commented Apr 30, 2024

I experienced a lot of lags too, with Appimage v0.21.4, even on short notes (3 pages, but with a few emoji images).

@QubaB

This comment was marked as off-topic.

@danielwmoore
Copy link

I was also experiencing lags during autosave. I have disabled autosave and just make sure I save before I exit. Dramatically improved the usage of the app.

@6b6279
Copy link

6b6279 commented Sep 15, 2024

I haven't done an exhaustive search, but 0.21.0 seems to not have this issue. I reckon it's caused by a95f44b, which makes it a duplicate of #1189. Autosaving causes roughly the same amount of lag as simply saving to exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants