Is it possible that the changed code for fluent function-calls more human readable

[hdietrich-timespin]

Is it possible that the changed code more human readable is like that:

$or = $queryBuilder->expr()->or();

   $or->with($queryBuilder->expr()->eq('znumber', ":search"))
            ->with($queryBuilder->expr()->eq('type', ":search"))
            ->with($queryBuilder->expr()->like('first_name', ":likeSearch"))
            ->with($queryBuilder->expr()->like('last_name', ":likeSearch"))
 

rector changes is very complicate, horrible and have to much redundancy code:

unformatted changes:

 ((($or = $or->with($queryBuilder->expr()->eq('znumber', ":search"))) = ($or = $or->with($queryBuilder->expr()->eq('znumber', ":search")))->with($queryBuilder->expr()->eq('type', ":search"))) = ($or->add($queryBuilder->expr()->eq('znumber', ":search")) = ($or = $or->with($queryBuilder->expr()->eq('znumber', ":search")))->with($queryBuilder->expr()->eq('type', ":search")))->with($queryBuilder->expr()->like('first_name', ":likeSearch"))) = ($or->add($queryBuilder->expr()->eq('znumber', ":search"))
        ->add($queryBuilder->expr()->eq('type', ":search")) = ($or->add($queryBuilder->expr()->eq('znumber', ":search")) = ($or = $or->with($queryBuilder->expr()->eq('znumber', ":search")))->with($queryBuilder->expr()->eq('type', ":search")))->with($queryBuilder->expr()->like('first_name', ":likeSearch")))->with($queryBuilder->expr()->like('last_name', ":likeSearch"))
 ;

I formatted changes manually for human readability:

       (
           (
               (
                    $or = $or->with($queryBuilder->expr()->eq('znumber', ":search"))
               ) = (
                       $or = $or->with($queryBuilder->expr()->eq('znumber', ":search"))
               )->with($queryBuilder->expr()->eq('type', ":search"))
           ) = (
               $or->add($queryBuilder->expr()->eq('znumber', ":search"))
                   = ($or = $or->with($queryBuilder->expr()->eq('znumber', ":search")))
                   ->with($queryBuilder->expr()->eq('type', ":search"))
           )->with($queryBuilder->expr()->like('first_name', ":likeSearch"))
       ) = ($or->add($queryBuilder->expr()->eq('znumber', ":search"))
               ->add($queryBuilder->expr()->eq('type', ":search"))
               = (
                    $or->add($queryBuilder->expr()->eq('znumber', ":search"))
                    = ($or = $or->with($queryBuilder->expr()->eq('znumber', ":search")))
                        ->with($queryBuilder->expr()->eq('type', ":search"))
                )->with($queryBuilder->expr()->like('first_name', ":likeSearch"))
       )->with($queryBuilder->expr()->like('last_name', ":likeSearch"));

[Patta]

https://github.com/sabbelasichon/typo3-rector/blob/main/docs/limitations.md#how-to-apply-coding-standards

[chrissonntag]

If you are looking for a solution that you can use in combination with --dry-run. There is none. But you could do the following:

• Format your code with php-cs-fixer - use https://github.com/TYPO3/coding-standards
• create a new branch in your project
• run rector
• Formst your code again with php-cs-fixer
• Push the changes to the new branch

You should now be able to comfortable see what changes where made by looking at the commit summary

[simonschaufi]

This has been asked 1000 times already. Rector is a code migration tool and not a code beautifier. Use other tools to format your code.

[hdietrich-timespin]

If I do not use fluent calls the rector changes are very better:

[hdietrich-timespin]

You can find reproduceable repo here https://github.com/hdietrich-timespin/typo3-rector-testrepo/tree/bug_issues_4196.

You can start rector process with:

cd /path_to/hdietrich-timespin/typo3-rector-testrepo
composer install
cd Projects/Typo3_12
php ../../vendor/bin/rector  process typo3conf/ext/t3tstest/Classes/Domain/Repository --dry-run -vvv --debug