-
-
Notifications
You must be signed in to change notification settings - Fork 63
/
RemoveTSFEConvOutputCharsetCallsRector.php
87 lines (75 loc) · 2.46 KB
/
RemoveTSFEConvOutputCharsetCallsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO312\v0;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Ssch\TYPO3Rector\NodeResolver\Typo3NodeResolver;
use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-97065-TYPO3FrontendAlwaysRenderedInUTF-8.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v12\v0\typo3\RemoveTSFEConvOutputCharsetCallsRector\RemoveTSFEConvOutputCharsetCallsRectorTest
*/
final class RemoveTSFEConvOutputCharsetCallsRector extends AbstractRector implements DocumentedRuleInterface
{
/**
* @readonly
*/
private Typo3NodeResolver $typo3NodeResolver;
public function __construct(Typo3NodeResolver $typo3NodeResolver)
{
$this->typo3NodeResolver = $typo3NodeResolver;
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
if (! $this->isName($node->name, 'convOutputCharset')) {
return null;
}
return $node->args[0]->value;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Removes usages of TSFE->convOutputCharset(...)', [new CodeSample(
<<<'CODE_SAMPLE'
$tsfe = GeneralUtility::makeInstance(TypoScriptFrontendController::class);
$foo = $GLOBALS['TSFE']->convOutputCharset($content);
$bar = $tsfe->convOutputCharset('content');
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$tsfe = GeneralUtility::makeInstance(TypoScriptFrontendController::class);
$foo = $content;
$bar = 'content';
CODE_SAMPLE
)]);
}
private function shouldSkip(MethodCall $methodCall): bool
{
if ($this->typo3NodeResolver->isAnyMethodCallOnGlobals(
$methodCall,
Typo3NodeResolver::TYPO_SCRIPT_FRONTEND_CONTROLLER
)) {
return false;
}
return ! $this->isObjectType(
$methodCall->var,
new ObjectType('TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController')
);
}
}