-
-
Notifications
You must be signed in to change notification settings - Fork 63
/
RemoveRelativeToCurrentScriptArgumentsRector.php
120 lines (99 loc) · 3.36 KB
/
RemoveRelativeToCurrentScriptArgumentsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO312\v0;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Stmt\Class_;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-96205-RemovalOfLastRelativeToCurrentScriptRemains.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v12\v0\typo3\RemoveRelativeToCurrentScriptArgumentsRector\RemoveRelativeToCurrentScriptArgumentsRectorTest
*/
final class RemoveRelativeToCurrentScriptArgumentsRector extends AbstractRector implements DocumentedRuleInterface
{
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class, Class_::class];
}
/**
* @param MethodCall|Class_ $node
*/
public function refactor(Node $node): ?Node
{
if ($node instanceof MethodCall) {
return $this->refactorMethodCall($node);
}
return $this->refactorClassMethod($node);
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Removes all usages of the relativeToCurrentScript parameter', [
new CodeSample(
<<<'CODE_SAMPLE'
/** @var AudioTagRenderer $audioTagRenderer */
$audioTagRenderer = GeneralUtility::makeInstance(AudioTagRenderer::class);
$foo = $audioTagRenderer->render($file, $width, $height, $options, $relative);
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
/** @var AudioTagRenderer $audioTagRenderer */
$audioTagRenderer = GeneralUtility::makeInstance(AudioTagRenderer::class);
$foo = $audioTagRenderer->render($file, $width, $height, $options);
CODE_SAMPLE
),
]);
}
private function shouldSkipMethodCall(MethodCall $node): bool
{
if (! $this->isObjectType(
$node->var,
new ObjectType('TYPO3\\CMS\\Core\\Resource\\Rendering\\FileRendererInterface')
)) {
return true;
}
if (! $this->isName($node->name, 'render')) {
return true;
}
return ! isset($node->args[4]);
}
private function refactorMethodCall(MethodCall $node): ?MethodCall
{
if ($this->shouldSkipMethodCall($node)) {
return null;
}
unset($node->args[4]);
return $node;
}
private function refactorClassMethod(Class_ $node): ?Class_
{
$skip = true;
foreach ($node->implements as $implement) {
if ($this->isName($implement, 'TYPO3\\CMS\\Core\\Resource\\Rendering\\FileRendererInterface')) {
$skip = false;
}
}
if ($skip) {
return null;
}
$classMethods = $node->getMethods();
$hasChanged = false;
foreach ($classMethods as $classMethod) {
if (! $this->isName($classMethod->name, 'render')) {
continue;
}
if (! isset($classMethod->params[4])) {
continue;
}
unset($classMethod->params[4]);
$hasChanged = true;
}
return $hasChanged ? $node : null;
}
}