-
-
Notifications
You must be signed in to change notification settings - Fork 63
/
SubstituteGetIconFactoryAndGetPageRendererFromModuleTemplateRector.php
190 lines (163 loc) · 6.03 KB
/
SubstituteGetIconFactoryAndGetPageRendererFromModuleTemplateRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO311\v5;
use PhpParser\Modifiers;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Stmt\Class_;
use PHPStan\Type\ObjectType;
use Rector\NodeManipulator\ClassDependencyManipulator;
use Rector\PostRector\ValueObject\PropertyMetadata;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95235-PublicGetterOfServicesInModuleTemplate.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v11\v5\SubstituteGetIconFactoryAndGetPageRendererFromModuleTemplateRector\SubstituteGetIconFactoryAndGetPageRendererFromModuleTemplateRectorTest
*/
final class SubstituteGetIconFactoryAndGetPageRendererFromModuleTemplateRector extends AbstractRector implements DocumentedRuleInterface
{
/**
* @readonly
*/
private ClassDependencyManipulator $classDependencyManipulator;
public function __construct(ClassDependencyManipulator $classDependencyManipulator)
{
$this->classDependencyManipulator = $classDependencyManipulator;
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node): ?Node
{
$iconPropertyFetch = $this->nodeFactory->createPropertyFetch('this', 'iconFactory');
$iconFactoryMethodCalls = $this->findModuleTemplateMethodCallsByName(
$node,
'getIconFactory',
$iconPropertyFetch
);
$pageRendererPropertyFetch = $this->nodeFactory->createPropertyFetch('this', 'pageRenderer');
$pageRendererMethodCalls = $this->findModuleTemplateMethodCallsByName(
$node,
'getPageRenderer',
$pageRendererPropertyFetch
);
if (! $iconFactoryMethodCalls && ! $pageRendererMethodCalls) {
return null;
}
if ($iconFactoryMethodCalls) {
$this->addIconFactoryToConstructor($node);
}
if ($pageRendererMethodCalls) {
$this->addPageRendererToConstructor($node);
}
return $node;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Use PageRenderer and IconFactory directly instead of getting them from the ModuleTemplate',
[
new CodeSample(
<<<'CODE_SAMPLE'
class MyController extends ActionController
{
protected ModuleTemplateFactory $moduleTemplateFactory;
public function __construct(ModuleTemplateFactory $moduleTemplateFactory)
{
$this->moduleTemplateFactory = $moduleTemplateFactory;
}
public function myAction(): ResponseInterface
{
$moduleTemplate = $this->moduleTemplateFactory->create($this->request);
$moduleTemplate->getPageRenderer()->loadRequireJsModule('Vendor/Extension/MyJsModule');
$moduleTemplate->setContent($moduleTemplate->getIconFactory()->getIcon('some-icon', Icon::SIZE_SMALL)->render());
return $this->htmlResponse($moduleTemplate->renderContent());
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class MyController extends ActionController
{
protected ModuleTemplateFactory $moduleTemplateFactory;
protected IconFactory $iconFactory;
protected PageRenderer $pageRenderer;
public function __construct(
ModuleTemplateFactory $moduleTemplateFactory,
IconFactory $iconFactory,
PageRenderer $pageRenderer
) {
$this->moduleTemplateFactory = $moduleTemplateFactory;
$this->iconFactory = $iconFactory;
$this->pageRenderer = $pageRenderer;
}
public function myAction(): ResponseInterface
{
$moduleTemplate = $this->moduleTemplateFactory->create($this->request);
$this->pageRenderer->loadRequireJsModule('Vendor/Extension/MyJsModule');
$moduleTemplate->setContent($this->iconFactory->getIcon('some-icon', Icon::SIZE_SMALL)->render());
return $this->htmlResponse($moduleTemplate->renderContent());
}
}
CODE_SAMPLE
),
]
);
}
private function findModuleTemplateMethodCallsByName(
Class_ $class,
string $methodCallName,
PropertyFetch $propertyFetch
): bool {
$hasChanged = false;
$this->traverseNodesWithCallable($class->stmts, function (Node $node) use (
$methodCallName,
&$hasChanged,
$propertyFetch
) {
if (! $node instanceof MethodCall) {
return null;
}
if (! $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType(
$node,
new ObjectType('TYPO3\CMS\Backend\Template\ModuleTemplate')
)) {
return null;
}
if (! $this->nodeNameResolver->isName($node->name, $methodCallName)) {
return null;
}
$hasChanged = true;
return $propertyFetch;
});
return $hasChanged;
}
private function addIconFactoryToConstructor(Class_ $class): void
{
$propertyMetadata = new PropertyMetadata(
'iconFactory',
new ObjectType('TYPO3\CMS\Core\Imaging\IconFactory'),
Modifiers::PRIVATE
);
$this->classDependencyManipulator->addConstructorDependency($class, $propertyMetadata);
}
private function addPageRendererToConstructor(Class_ $class): void
{
$propertyMetadata = new PropertyMetadata(
'pageRenderer',
new ObjectType('TYPO3\CMS\Core\Page\PageRenderer'),
Modifiers::PRIVATE
);
$this->classDependencyManipulator->addConstructorDependency($class, $propertyMetadata);
}
}