Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type not define in rpc.go #1

Open
powxiao opened this issue Oct 18, 2017 · 4 comments
Open

type not define in rpc.go #1

powxiao opened this issue Oct 18, 2017 · 4 comments

Comments

@powxiao
Copy link

powxiao commented Oct 18, 2017

I have already update github.com/kolo/xmlrpc, but xmlrpc.Struct and xmlrpc.Params are still undefine in rpc.go, how can I fix this issue?

@rynbrd
Copy link
Owner

rynbrd commented Oct 18, 2017

I'm not sure what issue you are having. Please include logs and the commands used to generate them.

@powxiao
Copy link
Author

powxiao commented Oct 19, 2017

I know the root case:
this package has remove the xmlrpc.Struct and xmlrpc.Parmas in commit 950d7060415dc98214ffbaa1d1340ebe4f983690 but your project still use them.
https://github.com/kolo/xmlrpc/commit/923b8036fe90ae5c0e42d867c341fd4b388c10c0#diff-b9152c487c4c18fb7018d7a04217d1af

your project cannot build successfully when use the latest github.com/kolo/xmlrpc.

maybe you should manage your third party package by vendorhttps://github.com/golang/dep

@rynbrd
Copy link
Owner

rynbrd commented Oct 20, 2017

This package predates vendoring by a wide margin. If you'd like to issue a PR to solve the issue and integrate dep then I'm open to reviewing it.

@newtonkishore
Copy link

Facing the same issue:

  1. With latest github.com/kolo/xmlrpc, go-supervisor is not building
  2. With github.com/kolo/xmlrpc [ 950d7060415dc98214ffbaa1d1340ebe4f983690 ], there are decoder issues with xmlrpc.

@powxiao : Were you able to use that commit to proceed? Do you have a working go-supervisor?

@bluedragonx : Can you let me know what is the commit id of kolo/xmlrpc you used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants