Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhandled rejection when running in npm repo #6

Closed
ghost opened this issue Jul 1, 2019 · 1 comment · Fixed by #7
Closed

unhandled rejection when running in npm repo #6

ghost opened this issue Jul 1, 2019 · 1 comment · Fixed by #7

Comments

@ghost
Copy link

ghost commented Jul 1, 2019

Thank you for this pro tip.

  1. git clone https://github.com/adopted-ember-addons/ember-page-title.git && cd ember-page-title
  2. run npm init rwjblue-release-it-setup

It works but I noticed the following printed to my terminal:

(node:7098) UnhandledPromiseRejectionWarning
(node:7098) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7098) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@rwjblue
Copy link
Owner

rwjblue commented Jul 1, 2019

Thanks for reporting! The last I looked into this, it was because the GH api is returning a redirect and the system I’m using to setup github labels doesn’t properly handle redirects. I reported that over in Financial-Times/github-label-sync#27 but haven’t seen any movement (the repo seems to be fairly silent in the last few months).

At the least, we should add a catch handler to our main to avoid the node warning RE: unhandled rejections, and then log the error to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant