Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation details of RoomPosition.findClosestByPath #55

Open
ASalvail opened this issue Sep 21, 2018 · 4 comments
Open

Implementation details of RoomPosition.findClosestByPath #55

ASalvail opened this issue Sep 21, 2018 · 4 comments
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue. C-unimplemented Feature that exists in Screeps, but that is yet unavailable in our API.

Comments

@ASalvail
Copy link
Collaborator

Alright, this one is a headache: https://docs.screeps.com/api/#RoomPosition.findClosestByPath

Our choices as I see it:

  • Don't implement it as it seems a very bad idea to use this method.
  • Implement it as people are probably used to it.

If we implement it, other considerations:

  • Implement the two versions with the two optional callbacks and an option on the algorithm.
  • Implement rust-side with calls to Room.find, Room.find_path and filtering done on the rust side. This suppose we are not using astar as this seems to be the old version of the algorithm.

As our support for other methods is growing, it becomes more and more tempting to use them rather than rely on the JS version.

@ASalvail ASalvail added C-enhancement Category: A PR with an enhancement or a proposed on in an issue. A-screeps-game-api labels Oct 8, 2018
@ASalvail ASalvail mentioned this issue Oct 15, 2018
63 tasks
@ASalvail ASalvail added the C-unimplemented Feature that exists in Screeps, but that is yet unavailable in our API. label Aug 22, 2019
@martsa1
Copy link

martsa1 commented Jan 2, 2020

Just bumped into this, and am curious how others work around this?

I get the feeling a rust way to do things would be nicer, but findClosestByPath is commonly referenced in a lot of screeps entry level material, so perhaps a nice way to solve this would be to write up some docs on the rust way to achieve a similar effect?

I'd be up for writing something like that, but I won't be in an experienced enough position to do so for a fair while.

@ASalvail
Copy link
Collaborator Author

ASalvail commented Jan 3, 2020

Well, this issue has been up for a year and a half, so there's no rush 😉
All contributions are very welcome!

@JCBurnside
Copy link

any update on this?

@BlueskyFR
Copy link

How did you guys went around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue. C-unimplemented Feature that exists in Screeps, but that is yet unavailable in our API.
Projects
None yet
Development

No branches or pull requests

5 participants