Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random_walk result not reproducible if the walk is biased #195

Open
jsun57 opened this issue Oct 23, 2023 · 8 comments
Open

random_walk result not reproducible if the walk is biased #195

jsun57 opened this issue Oct 23, 2023 · 8 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jsun57
Copy link

jsun57 commented Oct 23, 2023

As title. The issue comes from

pytorch_cluster/csrc/cuda/rw_cuda.cu

Line 146 in 29cd22b

time(NULL), rowptr.data_ptr<int64_t>(), col.data_ptr<int64_t>(),
,
where the seed is controlled by time(NULL) in rejection_sampling_kernel function. Please fix~
@rusty1s
Copy link
Owner

rusty1s commented Oct 24, 2023

Can you send a PR to fix this?

@jsun57
Copy link
Author

jsun57 commented Oct 25, 2023

While I can locate the issue, unfortunately I only have access to a university cluster which does not have nvcc installed... So I am not able to build from source to perform testing sadly

@rusty1s rusty1s added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 26, 2023
@rusty1s
Copy link
Owner

rusty1s commented Oct 26, 2023

Ok, I see if I can find time to implement this.

@jsun57
Copy link
Author

jsun57 commented Nov 15, 2023

Wondering if there are any updates on this

@jsun57
Copy link
Author

jsun57 commented Dec 18, 2023

Wondering if there are any updates on this~

@rusty1s
Copy link
Owner

rusty1s commented Dec 19, 2023

Not yet, sorry :(

@jsun57
Copy link
Author

jsun57 commented Mar 18, 2024

Would like to know if we have any updates.

1 similar comment
@jsun57
Copy link
Author

jsun57 commented Apr 22, 2024

Would like to know if we have any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rusty1s @jsun57