Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI for this repository isn't catching errors #39

Open
alexcrichton opened this issue Mar 18, 2019 · 0 comments
Open

CI for this repository isn't catching errors #39

alexcrichton opened this issue Mar 18, 2019 · 0 comments
Assignees
@ashleygwilliams

Comments

@alexcrichton
Copy link
Contributor

I first commited a bug in #37 which would cause the template to not build, but it was caught by @fitzgen's sharp eyes. Unfortunately though Travis didn't catch this.

The reason, I believe, is that cargo generate --git . --name testing, what Travis is currently doing, actually checks out the master branch of the repository rather than whatever branch the PR is set to be. This means that every PR is actually testing what's on master, not what's in the PR!
@alexcrichton alexcrichton mentioned this issue Mar 18, 2019
Merged
@ashleygwilliams ashleygwilliams self-assigned this Apr 1, 2019
midorishibukawa pushed a commit to midorishibukawa/wasm_game-of-life that referenced this issue Oct 3, 2021
@ashleygwilliams
Merge pull request rustwasm#39 from rustwasm/fix-issue-18
d9180ad 
Explain use case for this template and point to alternative templates…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashleygwilliams ashleygwilliams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @ashleygwilliams