Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode_length handles edge case wrong #77

Open
foofel opened this issue Dec 16, 2024 · 0 comments
Open

encode_length handles edge case wrong #77

foofel opened this issue Dec 16, 2024 · 0 comments

Comments

@foofel
Copy link

foofel commented Dec 16, 2024

I am not a spec expert, but as far as i can see (https://en.wikipedia.org/wiki/X.690#Length_octets), encoding a content length of 128 should result in two length octets not one.

if sz <= 128 {
should be <= 127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant