You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But does a line, entirely contained within an AABB, really intersect it? I would have difficulties pointing at any intersection point.
If it does, maybe this should be clearly documented in the trait?
Or maybe I should have implement some other trait?
I guess one could interpret intersection as "if anything occupies any part of the volume(for 3d) or area(for 2d) of an AABB, it's a hit"
Anyhow, could someone check if my patch is something you want include (or give some feedback)? I'd be happy to make a PR.
P. S. There is an issue I've noticed: If the Line skims the surface of the AABB it will not register as an intersection. But the same is true for Ray.intersects(AABB) tests (#27).
P.S.S In the process I implemented Try_From(Line)->Ray (Euclidian). Turns out I could not use it, but it is still in there.
The text was updated successfully, but these errors were encountered:
I need to test if an AABB3 intersects OR contains a Line3, so I wrote this patch
This seems to be in line with how
AABB3.intersects(AABB3)
andSphere3.intersects(Sphere3)
works:But does a line, entirely contained within an AABB, really intersect it? I would have difficulties pointing at any intersection point.
If it does, maybe this should be clearly documented in the trait?
Or maybe I should have implement some other trait?
I guess one could interpret intersection as "if anything occupies any part of the volume(for 3d) or area(for 2d) of an AABB, it's a hit"
Anyhow, could someone check if my patch is something you want include (or give some feedback)? I'd be happy to make a PR.
P. S. There is an issue I've noticed: If the Line skims the surface of the AABB it will not register as an intersection. But the same is true for
Ray.intersects(AABB)
tests (#27).P.S.S In the process I implemented
Try_From(Line)->Ray
(Euclidian). Turns out I could not use it, but it is still in there.The text was updated successfully, but these errors were encountered: