-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint integration #10
Comments
While this is strictly speaking against the statement of the README:
I approve the idea 👍 |
Actually, I'm not going to strictly follow the way of original library. Situation in gamedev sphere changed a lot, I'm planning to follow the currents. |
I took a look at this and created a huge mud-pile in my GitHub folder (the mint-integration branch). It will take some time to convert, as collision is a rich interface, but I definitely think it's a good idea. Traits that are needed to implement collision with cgmath should be private, and only basic traits like those from num-traits and mint should be public. It will certainly help reduce the log driver's waltz that most dependent library-writers have to do. |
Now that you are using cgmath 0.18, isn't this a one-line fix?
Could even add the other cgmath supported features as well (rand,swizzle,unstable) But this is quite redundant. All this does is to enable the feature in the cgmath crate, something that should already be done in the end-user toml (as long as the versions match). |
https://github.com/kvark/mint
The text was updated successfully, but these errors were encountered: