main: Handle errors gracefully in main() #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcvenegas
force-pushed
the
better-error-handling
branch
4 times, most recently
from
f9b9fad to
d0e73b7
Compare
Handle calls to `CLI`, `VMM::try_from()` and `vmm.run()`.
This commit adds anyhow and thiserror crates to handle errors.
The `anyhow` crate is used in the main binary to add extra context and
give a pretty view of error trace.
The create `thiserror` was used to easily derive `std::error::Error` for
errors provided by libs.
The new crates pulls the following extra crates: ```diff +name =
"proc-macro2" +name = "quote" +name = "syn" +name = "thiserror-impl"
+name = "unicode-xid" ```
New error format: examples: ```sh $ vmm-reference --kernel \
path=/path/vmlinuz-5.10.25 Error: Failed to create VMM from
configurations
Caused by: Error issuing an ioctl to KVM.
$ echo $? 1 ```
```sh $ vmm-reference --kernel path Error: Failed to parse CLI options
Caused by: Failed to parse cli Invalid input for kernel: Missing
required argument: path ```
``` $vmm-reference Error: Failed to parse CLI options
Caused by: Failed to parse cli error: The following required arguments
were not provided: --kernel <kernel>
USAGE: vmm-reference [OPTIONS] --kernel <kernel>
For more information try --help ```
Fixes: rust-vmm#99
Signed-off-by: Carlos Venegas <[email protected]>
jcvenegas
force-pushed
the
better-error-handling
branch
from
d0e73b7 to
8f2bb54
Compare
|
We typically do not want to add other dependencies, but I find @alexandruag @lauralt what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle calls to
CLI,VMM::try_from()andvmm.run().This commit adds
anyhowandthiserrorcrates tohandle errors.
The
anyhowcrate is used in the main binary to addextra context and give a pretty view of error trace.
The create
thiserrorwas used to easilyderive
std::error::Errorfor errors provided by libs.The new crates pulls the following extra crates:
New error format:
examples:
$ vmm-reference --kernel \ path=/path/vmlinuz-5.10.25 Error: Failed to create VMM from configurations Caused by: Error issuing an ioctl to KVM. $ echo $? 1$ vmm-reference --kernel path Error: Failed to parse CLI options Caused by: Failed to parse cli Invalid input for kernel: Missing required argument: pathFixes: #99
Signed-off-by: Carlos Venegas [email protected]