Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any block device to be root #97

Open
alexandruag opened this issue Mar 3, 2021 · 2 comments
Open

Allow any block device to be root #97

alexandruag opened this issue Mar 3, 2021 · 2 comments

Comments

@alexandruag
Copy link
Collaborator

We're currently appending root=/dev/vda to the kernel cmdline when a block device is marked as root. This may cause issues/confusion when we start supporting multiple block devices.
@alexandruag alexandruag mentioned this issue Mar 3, 2021
Merged
@gabhijit
Copy link
Contributor

gabhijit commented Mar 8, 2021

It might be a good idea to actually take root=/path/to/rootfs as a parameter, separate from other block devices path this comment has some more info about it. And then it can be made sure that root is indeed /dev/vda if present?

@alexandruag
Copy link
Collaborator Author

Thanks, this is an interesting approach! Will def keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabhijit @alexandruag