You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, it seems a copy of FC's tap device is already in place. Could you please help clarify the remaining work for this issue? Some action items I find are,
I think a good next step here is to add tests to the Tap abstractions in a way that is not requiring reading and writing on sockets because that would make the unit tests runnable only with TAP_ADMIN permissions and this is not something that we want to do.
Implement tap abstractions, or find if we can use existing crates (i.e. https://github.com/myrrlyn/tap).
We should be able to mock the tap functionality for testing (this is really important for writing unit tests, and not call read/write on sockets).
The text was updated successfully, but these errors were encountered: