Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap abstractions #94

Open
andreeaflorescu opened this issue Mar 1, 2021 · 3 comments
Open

Tap abstractions #94

andreeaflorescu opened this issue Mar 1, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@andreeaflorescu
Copy link
Member

Implement tap abstractions, or find if we can use existing crates (i.e. https://github.com/myrrlyn/tap).

We should be able to mock the tap functionality for testing (this is really important for writing unit tests, and not call read/write on sockets).

@lauralt lauralt added the help wanted Extra attention is needed label Mar 3, 2021
@0x00A5
Copy link

0x00A5 commented May 21, 2021

Hi, it seems a copy of FC's tap device is already in place. Could you please help clarify the remaining work for this issue? Some action items I find are,

  • Compare external crate
  • If using the existing one, add tests

@andreeaflorescu
Copy link
Member Author

I think a good next step here is to add tests to the Tap abstractions in a way that is not requiring reading and writing on sockets because that would make the unit tests runnable only with TAP_ADMIN permissions and this is not something that we want to do.

Does that make sense?

@0x00A5
Copy link

0x00A5 commented May 21, 2021

@andreeaflorescu Yep, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants