Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter test for shell scripts #44

Open
alxiord opened this issue Oct 1, 2020 · 3 comments
Open

Add linter test for shell scripts #44

alxiord opened this issue Oct 1, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@alxiord
Copy link
Member

alxiord commented Oct 1, 2020

Depends on rust-vmm/rust-vmm-container#30

@andreeaflorescu
Copy link
Member

The container with shellcheck is now published.

For this we need to:

  • find all bash files
  • run shellcheck for them

This can be a test under integration_tests, and it needs to be running in the buildkite pipeline.

@andreeaflorescu andreeaflorescu added the good first issue Good for newcomers label Feb 24, 2021
@nathanwhyte
Copy link

Hi Alexandra and Andreea,

I'm taking a Virtualization course at UT Austin and we've been asked to contribute to open-source virtualization repositories for one of our projects. Could I take a shot at resolving this issue?

@andreeaflorescu
Copy link
Member

Hmmm, we don't have a lot of shell scripts, and this is not a main focus of the project. I am not sure this is the right problem to tackle. I would be inclined to just close it instead. @lauralt wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants