Skip to content

Commit

Permalink
Bumps the MSRV of blas testing crates to 1.67
Browse files Browse the repository at this point in the history
This is unfortunately out of our control: users can select their blas implementations, and those implementations may not be MSRV 1.64, like ndarray itself. So we should add some documentation that makes this clear (or bump our MSRV). For now, we'll just add a gate in our test driver to handle this case
  • Loading branch information
akern40 committed Nov 13, 2024
1 parent d575848 commit 0223a2d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions crates/blas-tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ version = "0.1.0"
authors = ["bluss"]
publish = false
edition = "2018"
rust-version = "1.67"

[lib]
test = false
Expand Down
1 change: 1 addition & 0 deletions crates/numeric-tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ version = "0.1.0"
authors = ["bluss"]
publish = false
edition = "2018"
rust-version = "1.67"

[lib]
test = false
Expand Down
6 changes: 4 additions & 2 deletions scripts/all-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ cargo test -v -p ndarray -p ndarray-rand --release --features "$FEATURES" $QC_FE
# BLAS tests
cargo test -p ndarray --lib -v --features blas
cargo test -p blas-mock-tests -v
cargo test -p blas-tests -v --features blas-tests/openblas-system
cargo test -p numeric-tests -v --features numeric-tests/test_blas
if [[ "$CHANNEL" != "1.64.0" ]]; then # Fix openblas-build requiring MSRV 1.67
cargo test -p blas-tests -v --features blas-tests/openblas-system
cargo test -p numeric-tests -v --features numeric-tests/test_blas
fi

# Examples
cargo test --examples
Expand Down

0 comments on commit 0223a2d

Please sign in to comment.