Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Pointer bytes as Integers #547

Open
chorman0773 opened this issue Dec 6, 2024 · 6 comments
Open

Reading Pointer bytes as Integers #547

chorman0773 opened this issue Dec 6, 2024 · 6 comments

Comments

@chorman0773
Copy link
Contributor

chorman0773 commented Dec 6, 2024

This came up in rust-lang/reference#1664. I wanted to ask what T-opsem thinks about the behaviour of reading pointer bytes as integer types (or as char/bool/etc.).

As far as I can tell, there are two "sensible" behaviours, given that integers themselves do no carry provenance:

  • The pointer fragment is ignored,
  • Decoding error (thus undefined behaviour).

Given provenance monotonicity, which would be violated by the decoding error, it seems like the best option is that the fragments are ignored. Is there anything missed here? If not, can we get a formal sign off on this behaviour.

Note that I'm only considering the runtime behaviour, which can be a point against adopting the behaviour. Given that it's impossible to get the address of certain pointers in const-eval, it does need to be undefined behaviour (or otherwise an error) to read pointer bytes (to at least symbolic allocations) as integer types.

@saethlin
Copy link
Member

saethlin commented Dec 6, 2024

Given that it's impossible to get the address of certain pointers

Which pointers?

@chorman0773
Copy link
Contributor Author

I failed to clarify that. It was referring to the consteval AM, where allocations that exist outside of the particular constant evaluation (what I call symbolic pointers) can't be assigned an address.

@RalfJung
Copy link
Member

RalfJung commented Dec 6, 2024

Const-eval can't assign an address to any allocation, "inside" or "outside". (Not sure what you mean with that distinction.)

@chorman0773

This comment has been minimized.

@RalfJung

This comment has been minimized.

@RalfJung
Copy link
Member

RalfJung commented Dec 6, 2024

Anyway that sub-discussion seems off-topic here, please move it to Zulip. And please update the issue description to clarify that "certain pointers" refers to const-eval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants