bench-rustc broken after bootstrap removed from workspace

[adamgemmell]

I get this locally:

collector error: Failed to benchmark 'rustc', recorded: measure rustc: building rustc: expected success, got exit status: 1

stderr=error: current package believes it's in a workspace when it's not:
current:   /data_nvme0n1/rustc-perf/rust/src/bootstrap/Cargo.toml
workspace: /data_nvme0n1/rustc-perf/Cargo.toml

this may be fixable by adding `rust/src/bootstrap` to the `workspace.members` array of the manifest located at: /data_nvme0n1/rustc-perf/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.

rust-lang/rust#97513 removed bootstrap from the Rust workspace and is the first master commit since the last result: https://perf.rust-lang.org/bootstrap.html

Adding the Rust checkout to workspace.exclude fixes it for cases where the CWD is the root of rustc-perf, as the checkout is made in the CWD. Is there a better way?

Curiously the perf run on the PR itself seems to show bootstrap timings successfully. Does that CI run have a different working directory set?

[lqd]

cc @jyn514

[Mark-Simulacrum]

#1349 will fix this - just needs an approval from someone with write access.

[adamgemmell]

Glad we arrived at the same conclusion!

[lqd]

Done. I'll close this issue once we have bootstrap timings back.

[lqd]

The most recent run has bootstrap timings back. Closing this issue.