Stabilize #[coverage] attribute #130766
Stabilize #[coverage] attribute #130766
Conversation
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in coverage tests. cc @Zalathar rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
clarfonthey
force-pushed
the
stable-coverage-attribute
branch
from
dc49513 to
4b64d0d
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
stable-coverage-attribute
branch
from
4b64d0d to
2a11c1d
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
stable-coverage-attribute
branch
from
2a11c1d to
8037f0c
Compare
This comment has been minimized.
This comment has been minimized.
|
I will forward this to a more appropriate reviewer: r? @Zalathar |
|
FWIW, I'm currently working on fixing the test errors-- my computer kept crashing which made it difficult to run all the tests. Unfortunately a lot of coverage tests are now off-by-one due to the removal of the line enabling the feature, and they're all going to have to be re-blessed. |
clarfonthey
force-pushed
the
stable-coverage-attribute
branch
from
8037f0c to
53c467b
Compare
This comment has been minimized.
This comment has been minimized.
|
Appear to be getting very weird crashes with the debuginfo tests. From the backtrace: BacktraceI'm just going to run Yeah, okay. It might also be a difference in Python 3.12 that broke something too, but either way, the debuginfo tests show up as failing on my machine and the coverage tests show up as passing also, so, something weird is afoot. |
|
cc @rust-lang/lang |
I'm not exactly sure what debuginfo tests want, but bootstrap and other parts of compiletest AFAIK assumes Python 3.10 exactly, not 3.9 or 3.12. |
That feels worth documenting somewhere, considering how on my end that just shows up as LLVM hard-crashing and not as a wrong Python version. Like, maybe even worth having a virtualenv setup for the repo just to guarantee the right Python version is being used. |
|
I'm not sure if that's the root cause of your crashes, but if it is, then yes |
|
Well, I'm currently installing 3.10, so, we'll hopefully find out! |
|
Actually sorry minor correction: it's not bootstrap that expects Python 3.10 (as I see there is a toolstate check that goes through 3.10+ as well), but something in compiletest (maybe debuginfo tests?) expect Python 3.10 dll to be available. EDIT: I remembered what it is, it's lldb debuginfo tests, that requires Python 3.10 dll to be in the |
|
|
You linked #128392 twice, which I assume is a mistake. |
|
Yeah, I'm giving up on getting the debuginfo tests working. But I'll poke around to see if I can get the other tests to replicate their issues. I would have to downgrade my system Python version, since the tests explicitly link |
|
It seems that even running the test suite via docker, I can't replicate the latest errors. Running Looks like I've stumbled my way into the realm of cursed compiler testing issues that I don't know how to fix. |
…e, r=<try> Stabilize #[coverage] attribute Closes rust-lang#84605, which passed FCP. Stabilisation report here: rust-lang#84605 (comment) Also added to reference here: rust-lang/reference#1628 --- try-job: aarch64-apple try-job: x86_64-gnu try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
I guess I'll begrudgingly set up a test docker image and do it that way. Heading out soon but I can at least start the build now and let it run while I'm shopping, since it'll be quite a while. |
clarfonthey
force-pushed
the
stable-coverage-attribute
branch
from
cccbaae to
cb487cc
Compare
|
Apparently, blessing the Maybe third time's the charm? |
…e, r=<try> Stabilize #[coverage] attribute Closes rust-lang#84605, which passed FCP. Stabilisation report here: rust-lang#84605 (comment) Also added to reference here: rust-lang/reference#1628 --- try-job: aarch64-apple try-job: x86_64-gnu try-job: x86_64-msvc
|
☀️ Try build successful - checks-actions |
|
@bors r=@wesleywiser (does delegate let me do this?) edit: fair enough |
|
@clarfonthey: 🔑 Insufficient privileges: Not in reviewers |
|
@bors delegate+ |
|
✌️ @clarfonthey, you can now approve this pull request! If @jhpratt told you to " |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Closes #84605, which passed FCP.
Stabilisation report here: #84605 (comment)
Also added to reference here: rust-lang/reference#1628
try-job: aarch64-apple
try-job: x86_64-gnu
try-job: x86_64-msvc