regression: parameter type may not live long enough

[Mark-Simulacrum]

• https://crater-reports.s3.amazonaws.com/beta-1.74-4/beta-2023-10-21/gh/helium.helium-packet-router-ingest/log.txt

[INFO] [stdout] error[E0310]: the parameter type `S` may not live long enough
[INFO] [stdout]   --> src/uplink/ingest.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 | /     tonic::transport::Server::builder()
[INFO] [stdout] 21 | |         .add_service(PacketServer::new(Gateways::new(sender)))
[INFO] [stdout]    | |______________________________________________________________^ ...so that the type `S` will meet its required lifetime bounds
[INFO] [stdout]    |
[INFO] [stdout] help: consider adding an explicit lifetime bound...
[INFO] [stdout]    |
[INFO] [stdout] 19 | pub async fn start<S: UplinkIngest + Clone + 'static>(sender: S, addr: SocketAddr) -> Result {
[INFO] [stdout]    |                                            +++++++++

[apiraino]

cargo-bisect seems to point at nightly 2023-09-24 13e6f24 cc@cjgillot

searched nightlies: from nightly-2023-08-30 to nightly-2023-10-23
regressed nightly: nightly-2023-09-24
searched commit range: e4133ba...13e6f24
regressed commit: 13e6f24

bisected with cargo-bisect-rustc v0.6.7

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc 2023-08-30 --regress error -- check 

is it a breaking change, something we need to fix or something that can be fixed downstream?

[apiraino]

If this is really linked to #117059, maybe same priority also (Zulip discussion).

@rustbot label -I-prioritize +P-high

[jackh726]

We talked about this in the types team meeting today.

We agreed that there is a missing (or extra, depending how you look at it) 'static bound, and this regression is really a bug fix. We're going to try to put up a fix PR to the regressed crate, though.

@rfcbot fcp close

[rfcbot]

Team member @jackh726 has proposed to close this. The next step is review by the rest of the tagged team members:

• @BoxyUwU
• @aliemjay
• @compiler-errors
• @jackh726
• @lcnr
• @nikomatsakis
• @oli-obk
• @spastorino

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[nikomatsakis]

@rfcbot reviewed

[nikomatsakis]

We should notify authors of the helium crate and, ideally, open a PR with the 'static bound.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[nikomatsakis]

Hey @michaeldjeffrey -- a heads-up that a recent soundness fix seems to be affected the code you contributed about 3 months ago to Helium! The fix is to add S: 'static.

[rfcbot]

The final comment period, with a disposition to close, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.