Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not_unsafe_ptr_arg_deref update documentation #10116

Merged
merged 1 commit into from
Dec 25, 2022
Merged

not_unsafe_ptr_arg_deref update documentation #10116

merged 1 commit into from
Dec 25, 2022

Conversation

tgross35
Copy link
Contributor

changelog: [not_unsafe_ptr_arg_deref]: strengthened documentation wording, fixes #7714

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 25, 2022
@tgross35 tgross35 mentioned this pull request Dec 25, 2022
Closed
llogiq
llogiq reviewed Dec 25, 2022
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I only have one small suggestion, otherwise it's good to merge.

clippy_lints/src/functions/mod.rs Outdated Show resolved Hide resolved
@llogiq
Copy link
Contributor

llogiq commented Dec 25, 2022

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 25, 2022

📌 Commit 12f2dea has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 25, 2022

⌛ Testing commit 12f2dea with merge 4f1bae0...

@bors
Copy link
Contributor

bors commented Dec 25, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 4f1bae0 to master...

@bors bors merged commit 4f1bae0 into rust-lang:master Dec 25, 2022
@tgross35 tgross35 deleted the patch-1 branch December 25, 2022 17:34
@tgross35
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq left review comments

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve explanation of not_unsafe_ptr_arg_deref
4 participants
@tgross35 @rustbot @llogiq @bors