manual_let_else suggests incorrect code change

[nyurik]

Summary

Having a ref modifier in the match statement is incorrectly dropped from the suggested code

Reproducer

I tried this code:

#![warn(clippy::manual_let_else)]

#[derive(Debug)]
enum TypeKind {
    Str(String),
    None,
}

fn bar(value: &String) {
    println!("Value: {value}");
}

fn foo(value: TypeKind) {
    let signature = match value {
        TypeKind::Str(ref val) => val,
        _ => {
            println!("No signature found");
            return;
        },
    };

    bar(signature);
}

fn main() {
    foo(TypeKind::Str("Hello".to_string()));
    foo(TypeKind::None);
}

I expected the match value {...} statement to be converted to this:

let TypeKind::Str(ref signature) = value else {
    println!("No signature found");
    return;
};

Instead, the suggestion is missing the ref keyword

Version

rustc 1.83.0 (90b35a623 2024-11-26)
binary: rustc
commit-hash: 90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf
commit-date: 2024-11-26
host: x86_64-unknown-linux-gnu
release: 1.83.0
LLVM version: 19.1.1

Additional Labels

@rustbot label +I-suggestion-causes-error