Spec inline assembly tests #1648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorman0773
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds inline tests for the inline-assembly chapter. These serve as both examples for users reading the text and a micro test suite that can be run against a rust compiler.
Most
r[]delimited rules have at least one test. Ones that don't are ones that can easily be tested (such as many of ther[asm.rules]).Identifiers are not updated to match #1635, but this should be a merge-compatible change. I'd recommend merging that one before this one however, unless there are major changes required on it.
A few tests are
no_run, they have been explained directly with html comments. If mdbook test can be improved to test for certain conditions (not full on ui_test), that would be useful, and the tests can be modified accordingly