diff --git a/src/vec/vec-zsts.md b/src/vec/vec-zsts.md index 6715f947..f6d72786 100644 --- a/src/vec/vec-zsts.md +++ b/src/vec/vec-zsts.md @@ -214,3 +214,20 @@ impl DoubleEndedIterator for RawValIter { ``` And that's it. Iteration works! + +One last thing that we need to take into account is that now when our vec gets dropped it deallocates the memory that was allocated during the time our vec was alive. With ZSTs we did not allocate any memory, and in fact we never do. So right now we have unsoundness in our code where we still try deallocate a `NonNull::dangling()` ptr that we use to simulate the ZST in our vec, This means that we would cause undefined behavior if we try to deallocate something that we never allocated (obviously and for the right reasons). To fix that, in our `RawVec` we are going to tweak our `Drop` trait and check that we deallocate only types that are sized. + +```rust,ignore +impl Drop for RawVec { + fn drop(&mut self) { + println!("RawVec Drop called, deallocating memory"); + if self.cap != 0 && std::mem::size_of::() > 0 { + let layout = std::alloc::Layout::array::(self.cap).unwrap(); + unsafe { + std::alloc::dealloc(self.ptr.as_ptr() as *mut _, layout); + } + } + } +} +``` +