Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESP-IDF c_char type #4195

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SergioGasquez
Copy link
Contributor

Description

Updates the c_chart type for ESP-IDF after rust-lang/rust#132975

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
    • Still not tested, hence the PR is still in draft

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is marked as a draft?

@SergioGasquez
Copy link
Contributor Author

@ivmarkov wanted to do a small test, that's why I marked it as draft until we confirm that it works, but if you think the change is small enough I can mark it as ready

@tgross35
Copy link
Contributor

Happy to have tests! There probably won't be another release until next week anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants