Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd add more socket TCP stack constants. #4193

Merged
merged 1 commit into from
Dec 12, 2024
Merged

freebsd add more socket TCP stack constants. #4193

merged 1 commit into from
Dec 12, 2024

Conversation

devnexen
Copy link
Contributor

ref

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @asomers could you double check this?

asomers
asomers approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are pretty obscure, but they all look correct to me. There are dozens more obscure TCP socket options, too.

@tgross35 tgross35 added this pull request to the merge queue Dec 12, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 12, 2024
Merged via the queue into rust-lang:main with commit dd47a01 Dec 12, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

@asomers asomers asomers approved these changes

Assignees

@tgross35 tgross35

Labels
O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @rustbot @asomers @tgross35