Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use core::mem::offset_of #4182

Closed
wants to merge 1 commit into from
Closed

fix: use core::mem::offset_of #4182

wants to merge 1 commit into from

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Dec 7, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@zzau13 zzau13 closed this Dec 7, 2024
@zzau13 zzau13 deleted the fix/use-offset_of branch December 7, 2024 21:33
@tgross35
Copy link
Contributor

tgross35 commented Dec 7, 2024 •
edited
Loading

Thanks for taking a look at this, but indeed we can't use offset_of until our MSRV eventually reaches 1.77. For anything like this, a FIXME(msrv) to clarify would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
O-linux O-unix S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzau13 @rustbot @tgross35