Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add caching #4178

Merged
merged 1 commit into from
Dec 7, 2024
Merged

ci: Add caching #4178

merged 1 commit into from
Dec 7, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Dec 7, 2024

We have a handful of jobs that could benefit from reusing the target directory. Make use of Swatinem/rust-cache to do so.

Something still isn't quite right since the largest job only seems to be restoring a portion of the cache, but this still shows an improvement for most jobs.

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 force-pushed the ci-caching branch 3 times, most recently from 4d5dd06 to bc64efe Compare December 7, 2024 05:45
@tgross35 tgross35 changed the title Add CI caching ci: Add caching Dec 7, 2024
We have a handful of jobs that could benefit from reusing the target
directory. Make use of Swatinem/rust-cache to do so.

Something still isn't quite right since the largest job only seems to
be restoring a portion of the cache, but this still shows an improvement
for most jobs.
@tgross35 tgross35 enabled auto-merge December 7, 2024 05:51
@tgross35 tgross35 added this pull request to the merge queue Dec 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2024
@tgross35 tgross35 added this pull request to the merge queue Dec 7, 2024
Merged via the queue into rust-lang:main with commit 9b88158 Dec 7, 2024
45 checks passed
@tgross35 tgross35 deleted the ci-caching branch December 7, 2024 09:51
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 9, 2024
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 9, 2024
We have a handful of jobs that could benefit from reusing the target
directory. Make use of Swatinem/rust-cache to do so.

Something still isn't quite right since the largest job only seems to
be restoring a portion of the cache, but this still shows an improvement
for most jobs.

(backport <rust-lang#4178>)
(cherry picked from commit af7e126)
@tgross35 tgross35 mentioned this pull request Dec 9, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI-related items O-unix O-x86 S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants