Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Debug impl for unions opaque #4176

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Dec 7, 2024

Fixes #4118

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

tgross35 commented Dec 7, 2024

Thanks for working on this!

I'll take a more in-depth look soon, but why did this add core::cmp to Eq and PartialEq? If it is related to rustc-dep-of-std then that can be disregarded, we don't need to support both rustc-dep-of-std and extra-traits being enabled at the same time.

@zzau13 zzau13 force-pushed the fix/4118 branch 2 times, most recently from a6fa777 to ef755e9 Compare December 7, 2024 01:03
ci/run.sh Outdated Show resolved Hide resolved
@zzau13 zzau13 changed the title fix: make Debug impl unions opaque & miss import fix: make Debug impl for unions opaque Dec 7, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in OpenBSD module

cc @semarie

@zzau13 zzau13 force-pushed the fix/4118 branch 5 times, most recently from 35d8dd2 to 8141c4b Compare December 7, 2024 02:04
@tgross35
Copy link
Contributor

tgross35 commented Dec 7, 2024

Fyi the current error comes from a new lint in a recent nightly, I'll have it fixed soon #4177

@tgross35
Copy link
Contributor

tgross35 commented Dec 7, 2024

Feel free to cherry pick 99f4dd9 so you get CI results now, I can rebase once things turn green.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!

@tgross35 tgross35 added this pull request to the merge queue Dec 7, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 7, 2024
Merged via the queue into rust-lang:main with commit 5f6c5b0 Dec 7, 2024
45 checks passed
@tgross35 tgross35 mentioned this pull request Dec 7, 2024
@zzau13 zzau13 deleted the fix/4118 branch December 7, 2024 09:27
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 9, 2024
(backport <rust-lang#4176>)
(cherry picked from commit 6faa521)

[ resolve conflicts and update based on some main vs. 0.2 differences -
  Trevor ]
@tgross35 tgross35 mentioned this pull request Dec 9, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 9, 2024
(backport <rust-lang#4176>)
(cherry picked from commit 6faa521)

[ resolve conflicts and update based on some main vs. 0.2 differences -
  Trevor ]
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
@tgross35 tgross35 mentioned this pull request Dec 9, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Debug implementation for unions always opaque
3 participants