-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make Debug impl for unions opaque #4176
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks for working on this! I'll take a more in-depth look soon, but why did this add |
a6fa777
to
ef755e9
Compare
35d8dd2
to
8141c4b
Compare
Fyi the current error comes from a new lint in a recent nightly, I'll have it fixed soon #4177 |
Feel free to cherry pick 99f4dd9 so you get CI results now, I can rebase once things turn green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this!
(backport <rust-lang#4176>) (cherry picked from commit 6faa521) [ resolve conflicts and update based on some main vs. 0.2 differences - Trevor ]
(backport <rust-lang#4176>) (cherry picked from commit 6faa521) [ resolve conflicts and update based on some main vs. 0.2 differences - Trevor ]
Fixes #4118