Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performing http requests should signal to the user when the requests time out / are otherwise unavailable #62

Open
tinaun opened this issue Nov 16, 2020 · 3 comments

Comments

@tinaun
Copy link
Contributor

tinaun commented Nov 16, 2020

for example, play.rust-lang.org is down for me as i write this, but when i call the ?eval or ?play commands, there's no user visible feedback that the bot tried to make an http request and failed (it gets logged as an error, but it's not communicated to the end user in any way). without a bot response, the user may think that either the bot is broken or their command syntax is wrong.

ideally, this should be done at a high level and individual commands should be able to make http requests whenever without having to explicitly handle returning a message response to the user on a timeout

@tinaun tinaun changed the title commands that perform http requests should signal to the user when the requests time out / are otherwise unavailable performing http requests should signal to the user when the requests time out / are otherwise unavailable Nov 16, 2020
@kangalio
Copy link

kangalio commented Feb 1, 2021

This is a subset of #17

@technetos
Copy link
Member

This is a subset of #17

Kinda, error reporting is not uniform across the bot.

@khionu
Copy link
Member

khionu commented Feb 1, 2021

That said, I agree that this is an error that can be covered by #17. The centralized error handling can match on the error, censoring ones that don't match safe-to-show errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants