From bb5fc3676ec10684deaf5c32abacbe8dbc2c0e6d Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Thu, 12 Dec 2024 15:40:51 +0800
Subject: [PATCH 1/8] crate-sidebar: Fix deprecations

This fixes deprecations:
- Do not use A() on an EmberData PromiseManyArray
---
 app/components/crate-sidebar.hbs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/components/crate-sidebar.hbs b/app/components/crate-sidebar.hbs
index c588da0733..aebe8de637 100644
--- a/app/components/crate-sidebar.hbs
+++ b/app/components/crate-sidebar.hbs
@@ -94,7 +94,7 @@
   </div>
 
   {{#unless @crate.categories.isPending}}
-    {{#if @crate.categories}}
+    {{#if @crate.categories.length}}
       <div>
         <h2 local-class="heading">Categories</h2>
         <ul local-class="categories">

From 74c2d223b3d2bcec24b20c0e74f675f87303542e Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Thu, 12 Dec 2024 16:22:46 +0800
Subject: [PATCH 2/8] crate.index: Load `downloadsContext.version_downloads`
 explicitly with a task

This fixes the following deprecations:
 - The get method on ember-data's PromiseManyArray is deprecated.
---
 app/controllers/crate/version.js | 8 +++++++-
 app/routes/crate/version.js      | 3 +++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/app/controllers/crate/version.js b/app/controllers/crate/version.js
index ca857bb165..50931f5a40 100644
--- a/app/controllers/crate/version.js
+++ b/app/controllers/crate/version.js
@@ -24,7 +24,7 @@ export default class CrateVersionController extends Controller {
     this.stackedGraph = false;
   }
 
-  @alias('downloadsContext.version_downloads.content') downloads;
+  @alias('loadDownloadsTask.last.value') downloads;
   @alias('model.crate') crate;
   @alias('model.requestedVersion') requestedVersion;
   @alias('model.version') currentVersion;
@@ -62,4 +62,10 @@ export default class CrateVersionController extends Controller {
 
     return readme;
   });
+
+  // This task would be `perform()` in setupController
+  loadDownloadsTask = task(async () => {
+    let downloads = await this.downloadsContext.version_downloads;
+    return downloads;
+  });
 }
diff --git a/app/routes/crate/version.js b/app/routes/crate/version.js
index 41bf71de95..0be64bfef4 100644
--- a/app/routes/crate/version.js
+++ b/app/routes/crate/version.js
@@ -51,6 +51,9 @@ export default class VersionRoute extends Route {
     waitForPromise(controller.loadReadmeTask.perform()).catch(() => {
       // ignored
     });
+    waitForPromise(controller.loadDownloadsTask.perform()).catch(() => {
+      // ignored
+    });
 
     let { crate, version } = model;
     if (!crate.documentation || crate.documentation.startsWith('https://docs.rs/')) {

From 2e536ffebf181290be0a2288ed4edcf5c7ae89b9 Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 11:56:38 +0800
Subject: [PATCH 3/8] models/crate: Make `owners` getter rely on
 `loadOwnersTask`

This fixes the following deprecations:
- The toArray method on ember-data's PromiseManyArray is deprecated.
- The `toArray` method on the class ManyArray is deprecated.

by explicitly loading `owners` with a task.
---
 app/models/crate.js                               | 13 ++++++++++---
 app/routes/crate/version.js                       |  5 +++++
 .../crate-sidebar/playground-button-test.js       |  4 ++++
 .../components/crate-sidebar/toml-snippet-test.js |  3 +++
 tests/components/owners-list-test.js              | 15 +++++----------
 5 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/app/models/crate.js b/app/models/crate.js
index cb01764c7b..df6ae3cad9 100644
--- a/app/models/crate.js
+++ b/app/models/crate.js
@@ -1,8 +1,10 @@
 import Model, { attr, hasMany } from '@ember-data/model';
+import { assert } from '@ember/debug';
 import { waitForPromise } from '@ember/test-waiters';
 import { cached } from '@glimmer/tracking';
 
 import { apiAction } from '@mainmatter/ember-api-actions';
+import { task } from 'ember-concurrency';
 
 export default class Crate extends Model {
   @attr name;
@@ -66,9 +68,9 @@ export default class Crate extends Model {
   }
 
   get owners() {
-    let teams = this.owner_team.toArray() ?? [];
-    let users = this.owner_user.toArray() ?? [];
-    return [...teams, ...users];
+    let { last } = this.loadOwnersTask;
+    assert('`loadOwnersTask.perform()` must be called before accessing `owners`', last != null);
+    return last?.value ?? [];
   }
 
   async follow() {
@@ -100,6 +102,11 @@ export default class Crate extends Model {
       throw response;
     }
   }
+
+  loadOwnersTask = task(async () => {
+    let [teams, users] = await Promise.all([this.owner_team, this.owner_user]);
+    return [...(teams ?? []), ...(users ?? [])];
+  });
 }
 
 function compareVersionBySemver(a, b) {
diff --git a/app/routes/crate/version.js b/app/routes/crate/version.js
index 0be64bfef4..bc83718357 100644
--- a/app/routes/crate/version.js
+++ b/app/routes/crate/version.js
@@ -56,6 +56,11 @@ export default class VersionRoute extends Route {
     });
 
     let { crate, version } = model;
+
+    waitForPromise(crate.loadOwnersTask.perform()).catch(() => {
+      // ignored
+    });
+
     if (!crate.documentation || crate.documentation.startsWith('https://docs.rs/')) {
       version.loadDocsStatusTask.perform().catch(error => {
         // report unexpected errors to Sentry and ignore `ajax()` errors
diff --git a/tests/components/crate-sidebar/playground-button-test.js b/tests/components/crate-sidebar/playground-button-test.js
index 8bb21b8193..b088098e79 100644
--- a/tests/components/crate-sidebar/playground-button-test.js
+++ b/tests/components/crate-sidebar/playground-button-test.js
@@ -34,6 +34,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[data-test-playground-button]').doesNotExist();
@@ -46,6 +47,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     let expectedHref =
       'https://play.rust-lang.org/?edition=2021&code=use%20aho_corasick%3B%0A%0Afn%20main()%20%7B%0A%20%20%20%20%2F%2F%20try%20using%20the%20%60aho_corasick%60%20crate%20here%0A%7D';
@@ -64,6 +66,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     await waitFor('[data-test-owners]');
@@ -82,6 +85,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[data-test-playground-button]').doesNotExist();
diff --git a/tests/components/crate-sidebar/toml-snippet-test.js b/tests/components/crate-sidebar/toml-snippet-test.js
index 4fe5cbcb96..87a2c96e37 100644
--- a/tests/components/crate-sidebar/toml-snippet-test.js
+++ b/tests/components/crate-sidebar/toml-snippet-test.js
@@ -18,6 +18,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy command to clipboard"]').exists().hasText('cargo add foo');
@@ -35,6 +36,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy Cargo.toml snippet to clipboard"]').exists().hasText('foo = "1.0.0"');
@@ -47,6 +49,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy Cargo.toml snippet to clipboard"]').exists().hasText('foo = "1.0.0-alpha"');
diff --git a/tests/components/owners-list-test.js b/tests/components/owners-list-test.js
index 9581371108..18a0c9afe6 100644
--- a/tests/components/owners-list-test.js
+++ b/tests/components/owners-list-test.js
@@ -20,8 +20,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -44,8 +43,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -70,8 +68,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -93,8 +90,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="basic"]').exists();
@@ -120,8 +116,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();

From b09f4109ef3bcf23d344dfbbb6ba826640839d58 Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 14:34:43 +0800
Subject: [PATCH 4/8] models/crate: Add `hasOwnerUser()` fn that relies on
 `loadOwnerUserTask`

This extracts functionality from `isOwner` as a more generic method.
The data is loaded explicitly with `loadOwnerUserTask` to avoid
deprecations. A debugging assert is also included to inform if perform()
is not called before using it.
---
 app/models/crate.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/app/models/crate.js b/app/models/crate.js
index df6ae3cad9..fb08816ce6 100644
--- a/app/models/crate.js
+++ b/app/models/crate.js
@@ -67,6 +67,12 @@ export default class Crate extends Model {
     return new Set(map.values());
   }
 
+  hasOwnerUser(userId) {
+    let { last } = this.loadOwnerUserTask;
+    assert('`loadOwnerUserTask.perform()` must be called before calling `hasOwnerUser()`', last != null);
+    return (last?.value ?? []).some(({ id }) => id === userId);
+  }
+
   get owners() {
     let { last } = this.loadOwnersTask;
     assert('`loadOwnersTask.perform()` must be called before accessing `owners`', last != null);
@@ -103,6 +109,10 @@ export default class Crate extends Model {
     }
   }
 
+  loadOwnerUserTask = task(async () => {
+    return (await this.owner_user) ?? [];
+  });
+
   loadOwnersTask = task(async () => {
     let [teams, users] = await Promise.all([this.owner_team, this.owner_user]);
     return [...(teams ?? []), ...(users ?? [])];

From 5cc896df55579eb157ba182d6a1ad744c3d31bf8 Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 15:14:11 +0800
Subject: [PATCH 5/8] app: Simplify `isOwner` with `crate.hasOwnerUser(userId)`
 fn

This fixes the following deprecations:
- The findBy method on ember-data's PromiseManyArray is deprecated.
- The `findBy` method on the class ManyArray is deprecated.
---
 app/components/crate-header.js            | 13 ++-----------
 app/components/version-list/row.js        |  3 ++-
 app/controllers/crate/version.js          |  3 ++-
 app/routes/crate.js                       |  4 ++++
 tests/components/version-list-row-test.js |  3 +++
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/app/components/crate-header.js b/app/components/crate-header.js
index 4b73284482..a2649804ec 100644
--- a/app/components/crate-header.js
+++ b/app/components/crate-header.js
@@ -8,7 +8,6 @@ export default class CrateHeader extends Component {
   @service session;
 
   @alias('loadKeywordsTask.last.value') keywords;
-  @alias('loadOwnerUserTask.last.value') ownerUser;
 
   constructor() {
     super(...arguments);
@@ -16,22 +15,14 @@ export default class CrateHeader extends Component {
     this.loadKeywordsTask.perform().catch(() => {
       // ignore all errors and just don't display keywords if the request fails
     });
-    this.loadOwnerUserTask.perform().catch(() => {
-      // ignore all errors and just don't display settings if the request fails
-    });
   }
 
   get isOwner() {
-    let ownerUser = this.ownerUser ?? [];
-    let currentUserId = this.session.currentUser?.id;
-    return ownerUser.some(({ id }) => id === currentUserId);
+    let userId = this.session.currentUser?.id;
+    return this.args.crate?.hasOwnerUser(userId) ?? false;
   }
 
   loadKeywordsTask = task(async () => {
     return (await this.args.crate?.keywords) ?? [];
   });
-
-  loadOwnerUserTask = task(async () => {
-    return (await this.args.crate?.owner_user) ?? [];
-  });
 }
diff --git a/app/components/version-list/row.js b/app/components/version-list/row.js
index e94e17aafa..6eccca9108 100644
--- a/app/components/version-list/row.js
+++ b/app/components/version-list/row.js
@@ -48,7 +48,8 @@ export default class VersionRow extends Component {
   }
 
   get isOwner() {
-    return this.args.version.crate?.owner_user?.findBy('id', this.session.currentUser?.id);
+    let userId = this.session.currentUser?.id;
+    return this.args.version.crate.hasOwnerUser(userId);
   }
 
   @action setFocused(value) {
diff --git a/app/controllers/crate/version.js b/app/controllers/crate/version.js
index 50931f5a40..d9aa81e651 100644
--- a/app/controllers/crate/version.js
+++ b/app/controllers/crate/version.js
@@ -30,7 +30,8 @@ export default class CrateVersionController extends Controller {
   @alias('model.version') currentVersion;
 
   get isOwner() {
-    return this.crate.owner_user.findBy('id', this.session.currentUser?.id);
+    let userId = this.session.currentUser?.id;
+    return this.crate.hasOwnerUser(userId);
   }
 
   @alias('loadReadmeTask.last.value') readme;
diff --git a/app/routes/crate.js b/app/routes/crate.js
index 393daab881..f8646db3ba 100644
--- a/app/routes/crate.js
+++ b/app/routes/crate.js
@@ -1,6 +1,7 @@
 import { NotFoundError } from '@ember-data/adapter/error';
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
+import { waitForPromise } from '@ember/test-waiters';
 
 export default class CrateRoute extends Route {
   @service headData;
@@ -26,6 +27,9 @@ export default class CrateRoute extends Route {
   setupController(controller, model) {
     super.setupController(...arguments);
     this.headData.crate = model;
+    waitForPromise(model.loadOwnerUserTask.perform()).catch(() => {
+      // ignore all errors if the request fails
+    });
   }
 
   resetController() {
diff --git a/tests/components/version-list-row-test.js b/tests/components/version-list-row-test.js
index 3bcceac5b3..8c9990284f 100644
--- a/tests/components/version-list-row-test.js
+++ b/tests/components/version-list-row-test.js
@@ -19,6 +19,7 @@ module('Component | VersionList::Row', function (hooks) {
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
     let versions = (await crateRecord.versions).slice();
+    await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];
 
@@ -39,6 +40,7 @@ module('Component | VersionList::Row', function (hooks) {
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
     this.version = (await crateRecord.versions).slice()[0];
+    await crateRecord.loadOwnerUserTask.perform();
 
     await render(hbs`<VersionList::Row @version={{this.version}} />`);
     assert.dom('[data-test-release-track]').hasText('?');
@@ -72,6 +74,7 @@ module('Component | VersionList::Row', function (hooks) {
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
     let versions = (await crateRecord.versions).slice();
+    await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];
     this.thirdVersion = versions[2];

From 42ca1c75759dc40fb9cbb8d71b46b809bc0bc4be Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 17:56:49 +0800
Subject: [PATCH 6/8] crate.settings: Remove owner by native array method
 `splice`

This fixes the following deprecations:
- The removeObject method on ember-data's PromiseManyArray is deprecated.
- The `removeObject` method on the class ManyArray is deprecated.
---
 app/controllers/crate/settings.js | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/app/controllers/crate/settings.js b/app/controllers/crate/settings.js
index 94625c7ab3..72d38bdce9 100644
--- a/app/controllers/crate/settings.js
+++ b/app/controllers/crate/settings.js
@@ -36,10 +36,12 @@ export default class CrateSettingsController extends Controller {
 
       if (owner.kind === 'team') {
         this.notifications.success(`Team ${owner.get('display_name')} removed as crate owner`);
-        this.crate.owner_team.removeObject(owner);
+        let owner_team = await this.crate.owner_team;
+        removeOwner(owner_team, owner);
       } else {
         this.notifications.success(`User ${owner.get('login')} removed as crate owner`);
-        this.crate.owner_user.removeObject(owner);
+        let owner_user = await this.crate.owner_user;
+        removeOwner(owner_user, owner);
       }
     } catch (error) {
       let subject = owner.kind === 'team' ? `team ${owner.get('display_name')}` : `user ${owner.get('login')}`;
@@ -54,3 +56,10 @@ export default class CrateSettingsController extends Controller {
     }
   });
 }
+
+function removeOwner(owners, target) {
+  let idx = owners.indexOf(target);
+  if (idx !== -1) {
+    owners.splice(idx, 1);
+  }
+}

From 9538b229468d75e4e68163c2984b7adace3253e9 Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 13:59:48 +0800
Subject: [PATCH 7/8] models/crate: Load `crate.versions` explicitly with a
 task

A debugging assert is also included to inform missing `perform()` called
before accessing getters.

This fix the following deprecations:
- The toArray method on ember-data's PromiseManyArray is deprecated.
- The `toArray` method on the class ManyArray is deprecated.
---
 app/models/crate.js                       | 28 ++++++++++++++++++-----
 app/routes/crate/versions.js              | 12 ++++++++++
 tests/components/version-list-row-test.js |  6 ++---
 tests/models/version-test.js              |  8 +++----
 4 files changed, 41 insertions(+), 13 deletions(-)
 create mode 100644 app/routes/crate/versions.js

diff --git a/app/models/crate.js b/app/models/crate.js
index fb08816ce6..201be75d20 100644
--- a/app/models/crate.js
+++ b/app/models/crate.js
@@ -37,13 +37,23 @@ export default class Crate extends Model {
   @hasMany('dependency', { async: true, inverse: null }) reverse_dependencies;
 
   @cached get versionIdsBySemver() {
-    let versions = this.versions.toArray() ?? [];
-    return versions.sort(compareVersionBySemver).map(v => v.id);
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionIdsBySemver`', last != null);
+    let versions = last?.value ?? [];
+    return versions
+      .slice()
+      .sort(compareVersionBySemver)
+      .map(v => v.id);
   }
 
   @cached get versionIdsByDate() {
-    let versions = this.versions.toArray() ?? [];
-    return versions.sort(compareVersionByDate).map(v => v.id);
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionIdsByDate`', last != null);
+    let versions = last?.value ?? [];
+    return versions
+      .slice()
+      .sort(compareVersionByDate)
+      .map(v => v.id);
   }
 
   @cached get firstVersionId() {
@@ -51,8 +61,10 @@ export default class Crate extends Model {
   }
 
   @cached get versionsObj() {
-    let versions = this.versions.toArray() ?? [];
-    return Object.fromEntries(versions.map(v => [v.id, v]));
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionsObj`', last != null);
+    let versions = last?.value ?? [];
+    return Object.fromEntries(versions.slice().map(v => [v.id, v]));
   }
 
   @cached get releaseTrackSet() {
@@ -117,6 +129,10 @@ export default class Crate extends Model {
     let [teams, users] = await Promise.all([this.owner_team, this.owner_user]);
     return [...(teams ?? []), ...(users ?? [])];
   });
+
+  loadVersionsTask = task(async () => {
+    return (await this.versions) ?? [];
+  });
 }
 
 function compareVersionBySemver(a, b) {
diff --git a/app/routes/crate/versions.js b/app/routes/crate/versions.js
new file mode 100644
index 0000000000..1144952055
--- /dev/null
+++ b/app/routes/crate/versions.js
@@ -0,0 +1,12 @@
+import Route from '@ember/routing/route';
+import { waitForPromise } from '@ember/test-waiters';
+
+export default class VersionsRoute extends Route {
+  setupController(controller) {
+    super.setupController(...arguments);
+    let crate = this.modelFor('crate');
+    controller.set('crate', crate);
+    // TODO: Add error handling
+    waitForPromise(crate.loadVersionsTask.perform());
+  }
+}
diff --git a/tests/components/version-list-row-test.js b/tests/components/version-list-row-test.js
index 8c9990284f..e651767cc1 100644
--- a/tests/components/version-list-row-test.js
+++ b/tests/components/version-list-row-test.js
@@ -18,7 +18,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    let versions = (await crateRecord.versions).slice();
+    let versions = (await crateRecord.loadVersionsTask.perform()).slice();
     await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];
@@ -39,7 +39,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    this.version = (await crateRecord.versions).slice()[0];
+    this.version = (await crateRecord.loadVersionsTask.perform()).slice()[0];
     await crateRecord.loadOwnerUserTask.perform();
 
     await render(hbs`<VersionList::Row @version={{this.version}} />`);
@@ -73,7 +73,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    let versions = (await crateRecord.versions).slice();
+    let versions = (await crateRecord.loadVersionsTask.perform()).slice();
     await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];
diff --git a/tests/models/version-test.js b/tests/models/version-test.js
index 3cac01fcc6..92203fc2e2 100644
--- a/tests/models/version-test.js
+++ b/tests/models/version-test.js
@@ -167,7 +167,7 @@ module('Model | Version', function (hooks) {
       }
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -198,7 +198,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.2', yanked: true });
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -216,7 +216,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.1' });
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -229,7 +229,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.2' });
       this.server.create('version', { crate, num: '0.4.3', yanked: true });
       crateRecord = await this.store.findRecord('crate', crate.name, { reload: true });
-      versions = (await crateRecord.versions).slice();
+      versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),

From ac1a77441250fcf529ae0556e6a30904df96df37 Mon Sep 17 00:00:00 2001
From: eth3lbert <eth3lbert+dev@gmail.com>
Date: Fri, 13 Dec 2024 16:20:26 +0800
Subject: [PATCH 8/8] tests/components/crate-sidebar: Use the native array
 method `[0]`

This fixes the following deprecations:
- The `firstObject` method on the class ManyArray is deprecated.
---
 tests/components/crate-sidebar/playground-button-test.js | 8 ++++----
 tests/components/crate-sidebar/toml-snippet-test.js      | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/components/crate-sidebar/playground-button-test.js b/tests/components/crate-sidebar/playground-button-test.js
index b088098e79..48f7207d30 100644
--- a/tests/components/crate-sidebar/playground-button-test.js
+++ b/tests/components/crate-sidebar/playground-button-test.js
@@ -33,7 +33,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
@@ -46,7 +46,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     let expectedHref =
@@ -65,7 +65,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
@@ -84,7 +84,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
diff --git a/tests/components/crate-sidebar/toml-snippet-test.js b/tests/components/crate-sidebar/toml-snippet-test.js
index 87a2c96e37..33cb47ae65 100644
--- a/tests/components/crate-sidebar/toml-snippet-test.js
+++ b/tests/components/crate-sidebar/toml-snippet-test.js
@@ -17,7 +17,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
@@ -35,7 +35,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
@@ -48,7 +48,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    this.version = (await this.crate.versions).firstObject;
+    this.version = (await this.crate.versions).slice()[0];
     await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);