-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ANSI codes to report progress #11432
Comments
@rustbot label +A-console-output |
https://conemu.github.io/en/AnsiEscapeCodes.html#ConEmu_specific_OSC is the documentation page for it. Windows Terminal supports it, which makes it a worthwhile addition for both Windows and Linux, as WSL exists. |
@rustbot claim |
Enable triagebot's relabel functionality ### What does this PR try to resolve? This fixes the following failure that rustbot currently posts whenever someone tries to use "<b>`@</b><b>rustbot</b>` label" in this repository. > **Error**: The feature `relabel` is not enabled in this repository. > To enable it add its section in the `triagebot.toml` in the root of the repository. Unauthenticated relabel has been enabled in rust-lang/rust for nearly 4 years. People overwhelmingly use it in good faith. <br> ### How should we test and review this PR? Compare against https://github.com/rust-lang/rust/blob/1.66.0/triagebot.toml. Also skim through the 7 pages of labels on https://github.com/rust-lang/cargo/labels, whether it makes sense the ones I decided to allow arbitrary GitHub users to apply. <br> ### Additional information Attempted uses of "<b>`@</b><b>rustbot</b>` label", that failed, but this PR would allow: - #10343 (comment) - #10243 (comment) - #9982 (comment) - #9128 (comment) - #9067 (comment) - #8441 (comment) - #11432 (comment) - #8841 (comment) - #10820 (comment) - #10572 (comment) - #9114 (comment) - #8980 (comment) - #9064 (comment) - #8726 (comment) - #8089 (comment)
Triage: This is a cool enhancement but we need to be careful to not break people's emulators with unsupported escape code. In #11436 the author did some initial research, we'd like to see more info got collected back. Copied from #11436 (comment): Current testing progress:
Procedure:
Suggestions for future survey (#11436 (comment)): Two columns in the table:
|
Following the pattern of #12889 might offer a route for us to move forward with this
This also makes me wonder about using escape codes to set the window / tab title during the build to report progress. |
I am totally okay if it can be turned off. Found this resource of escape code we might want to support: https://tldp.org/HOWTO/Xterm-Title.html, though it's a bit old (1999). |
Problem
When the terminal is not in focus, there is no way to know the progress state of the compilation.
Proposed Solution
There exist escape codes that allow control of a "progress meter", that for example is shown on the taskbar in Windows.
Winget uses them, and the implementation can be seen at https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLICore/VTSupport.cpp. It mostly consists of adding the correct progress number, and clean up after the end.
Notes
I volunteer to make this change to this repo.
The text was updated successfully, but these errors were encountered: