From 705c4f1caec67fbdcfe13c8ef58d6dc2fbc3d8c4 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 29 Apr 2024 09:05:33 -0500 Subject: [PATCH] chore(ci): Don't check `cargo` against beta channel We already only partially check it and it has been a source of false positives. While there is trust in the job, contributors and maintainers go into the job assuming there is a problem and it takes time to break that assumption. If we lose trust in the job, we then won't trust it when it fails for other reasons. This also increases the risk of us not seeing other problems `bump-checks` is meant to find if the steps in the job get re-arranged to make this one of the early ones. --- crates/xtask-bump-check/src/xtask.rs | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/crates/xtask-bump-check/src/xtask.rs b/crates/xtask-bump-check/src/xtask.rs index a53a0a8bcfb..07148e554f5 100644 --- a/crates/xtask-bump-check/src/xtask.rs +++ b/crates/xtask-bump-check/src/xtask.rs @@ -118,10 +118,19 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?; let status = |msg: &str| gctx.shell().status(STATUS, msg); - // Don't check against beta and stable branches, - // as the publish of these crates are not tied with Rust release process. - // See `TO_PUBLISH` in publish.py. - let crates_not_check_against_channels = ["home"]; + let crates_not_check_against_channels = [ + // High false positive rate between beta branch and requisite version bump soon after + // + // Low risk because we always bump the "major" version after beta branch; we are + // only losing out on checks for patch releases. + // + // Note: this is already skipped in `changed` + "cargo", + // Don't check against beta and stable branches, + // as the publish of these crates are not tied with Rust release process. + // See `TO_PUBLISH` in publish.py. + "home", + ]; status(&format!("base commit `{}`", base_commit.id()))?; status(&format!("head commit `{}`", head_commit.id()))?;